From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH v2 net-next 5/9] net: stmmac: Add MDIO related functions
 for XGMAC2
Date: Fri, 3 Aug 2018 17:30:46 +0200
Message-ID: <20180803153046.GE15029@lunn.ch>
References: <cover.1533307909.git.joabreu@synopsys.com>
 <7eba8468b6e69fab66b1bf01f7a2b02b6c81b126.1533307909.git.joabreu@synopsys.com>
 <20180803152059.GC15029@lunn.ch>
 <21eb5877-ebdd-7710-e445-a60cb6e31ad6@synopsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:55003 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726981AbeHCR1j (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 3 Aug 2018 13:27:39 -0400
Content-Disposition: inline
In-Reply-To: <21eb5877-ebdd-7710-e445-a60cb6e31ad6@synopsys.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> > Probably you want to wait for the bus to be idle before you change the
> > mode to C22. Some PHYs can do both C22 and C45, e.g. EEE registers can
> > be in C45 space, while the rest are in C22.
> 
> Ok but I can't test C45 right now so maybe leave that change to
> when I can test it ?

I would fix this now. It probably cannot cause issues now, but it is
wrong. You are going to have to fix it some time, so why not now?

       Andrew