Re: [dm-crypt] Test suite is now FS-dependent (Re: cryptsetup 2.0.4)

From: Guilhem Moulin <guilhem@fripost.org>
To: Milan Broz <gmazyland@gmail.com>
Cc: dm-crypt <dm-crypt@saout.de>
Subject: Re: [dm-crypt] Test suite is now FS-dependent (Re: cryptsetup 2.0.4)
Date: Sun, 5 Aug 2018 04:40:35 +0800	[thread overview]
Message-ID: <20180804204035.GA19119@localhost.localdomain> (raw)
In-Reply-To: <8cc41ecf-6a13-8dc5-2618-97300c46397b@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]

Hi,

FWIW, ‘tests/blockwise-compat’ doesn't work consistently on all file
systems.  With

    BSIZE=$(stat -c "%o" $LOCAL_FILE)  ## 4096

`./unit-utils-io $LOCAL_FILE read_buffer $((BSIZE-1))` fails with ext4
(on read()) and tmpfs (on open(O_DIRECT)), but succeeds with btrfs (and
possibly other file systems).  The test-suite doesn't pass if that test
succeeds.

    ## ext4
    $ strace -e trace=openat,read ./unit-utils-io $LOCAL_FILE read_buffer $((BSIZE-1))
    […]
    openat(AT_FDCWD, "./blocwise_localfile", O_RDONLY|O_DIRECT) = 3
    read(3, 0x55914c895000, 4095)           = -1 EINVAL (Invalid argument)
    +++ exited with 1 +++

    ## tmpfs
    $ strace -e trace=openat,read ./unit-utils-io $LOCAL_FILE read_buffer $((BSIZE-1))
    […]
    openat(AT_FDCWD, "./blocwise_localfile", O_RDONLY|O_DIRECT) = -1 EINVAL (Invalid argument)
    Failed to open ./blocwise_localfile.
    +++ exited with 1 +++

    ## btrfs
    $ strace -e trace=openat,read ./unit-utils-io $LOCAL_FILE read_buffer $((BSIZE-1))
    […]
    openat(AT_FDCWD, "./blocwise_localfile", O_RDONLY|O_DIRECT) = 3
    read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4095) = 4095
    +++ exited with 0 +++

Just so you know :-)
Cheers,
-- 
Guilhem.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]