From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: [PATCH] devtools: fix symbol check for dash Date: Sun, 5 Aug 2018 11:38:47 +0200 Message-ID: <20180805093847.12935-1-thomas@monjalon.net> References: <1801169.BELgHmehf5@xps> Cc: dev@dpdk.org, stephen@networkplumber.org To: nhorman@tuxdriver.com Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1A6DD1B5B3 for ; Sun, 5 Aug 2018 11:39:08 +0200 (CEST) In-Reply-To: <1801169.BELgHmehf5@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The script check-symbol-change.sh was not running when /bin/sh redirects to dash. Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: nhorman@tuxdriver.com Reported-by: Stephen Hemminger Signed-off-by: Thomas Monjalon --- devtools/check-symbol-change.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 40b72073a..daaf45e14 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -4,8 +4,8 @@ build_map_changes() { - local fname=$1 - local mapdb=$2 + local fname="$1" + local mapdb="$2" cat "$fname" | awk ' # Initialize our variables @@ -80,7 +80,7 @@ build_map_changes() check_for_rule_violations() { - local mapdb=$1 + local mapdb="$1" local mname local symname local secname @@ -89,10 +89,10 @@ check_for_rule_violations() while read mname symname secname ar do - if [ "$ar" == "add" ] + if [ "$ar" = "add" ] then - if [ "$secname" == "unknown" ] + if [ "$secname" = "unknown" ] then # Just inform the user of this occurrence, but # don't flag it as an error -- 2.17.1