From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C76C46470 for ; Wed, 8 Aug 2018 21:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBD5D2150B for ; Wed, 8 Aug 2018 21:06:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBD5D2150B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731523AbeHHX2E (ORCPT ); Wed, 8 Aug 2018 19:28:04 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40462 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731180AbeHHX2E (ORCPT ); Wed, 8 Aug 2018 19:28:04 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id D91B1805CB; Wed, 8 Aug 2018 23:06:36 +0200 (CEST) Date: Wed, 8 Aug 2018 23:06:36 +0200 From: Pavel Machek To: Len Brown Cc: Prarit Bhargava , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , X86 ML , Linux PM list Subject: Re: [PATCH] x86/ACPI/cstate: Output AMD on APCI C1 FFH MWAIT AMD systems Message-ID: <20180808210636.GB15831@amd> References: <20180808174735.3114-1-prarit@redhat.com> <20180808195856.GA20912@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5I6of5zJg18YgZEa" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5I6of5zJg18YgZEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2018-08-08 16:01:41, Len Brown wrote: > I think it is sufficient to simply delete the "INTEL" in that string. >=20 > In the unlikely event that this "change to a kernel API" breaks > something, we can add it back. I'd just leave it alone. But yes, just deleting INTEL is better than patch below. Pavel > > On Wed 2018-08-08 13:47:35, Prarit Bhargava wrote: > > > commit 5209654a46ee ("x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on= AMD > > > systems") allows use of FFH for ACPI C1 but tools like cpupower and t= urbostat > > > display INTEL for the cstate description. > > > > > > Output "AMD" for AMD systems with FFH for ACPI C1. > > > > Um, is it good idea? > > > > First, you are changing kernel API. > > > > > @@ -107,9 +108,14 @@ static long acpi_processor_ffh_cstate_probe_cpu(= void *_cx) > > > "Monitor-Mwait will be used to enter C-%d state= \n", > > > cx->type); > > > } > > > - snprintf(cx->desc, > > > - ACPI_CX_DESC_LEN, "ACPI FFH INTEL MWAIT 0x%x", > > > - cx->address); > > > + if (c->x86_vendor =3D=3D X86_VENDOR_INTEL) > > > + snprintf(cx->desc, > > > + ACPI_CX_DESC_LEN, "ACPI FFH INTEL MWAIT 0x%x", > > > + cx->address); > > > + else > > > + snprintf(cx->desc, > > > + ACPI_CX_DESC_LEN, "ACPI FFH AMD MWAIT 0x%x", > > > + cx->address); > > > > Second, I read it as "Intel MWAIT" instruction is used. Yes, AMD cpu can > > use Intel MWAIT, too... > > > > Third, there are more CPU vendors out there. > > > > = Pavel > > -- > > (english) http://www.livejournal.com/~pavelmachek > > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses= /blog.html >=20 >=20 >=20 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --5I6of5zJg18YgZEa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAltrW1wACgkQMOfwapXb+vJWLgCfcOXaO54v1nJEGiGUaTQmym1z odYAoKDTlSJ/bF02Vq+k8g2vwtCHa2aq =YQfM -----END PGP SIGNATURE----- --5I6of5zJg18YgZEa--