From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Wed, 8 Aug 2018 23:15:47 +0100 Subject: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver In-Reply-To: <20180808190930.GQ20303@art_vandelay> References: <20180730164137.GD17271@n2100.armlinux.org.uk> <20180808190930.GQ20303@art_vandelay> Message-ID: <20180808221547.GN30658@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Aug 08, 2018 at 03:09:30PM -0400, Sean Paul wrote: > > -static const struct drm_encoder_helper_funcs tda998x_encoder_helper_funcs = { > > - .dpms = tda998x_encoder_dpms, > > - .prepare = tda998x_encoder_prepare, > > - .commit = tda998x_encoder_commit, > > - .mode_set = tda998x_encoder_mode_set, > > -}; > > Now that encoder is a stub, it should really be removed from here. The encoder > should be instantiated elsewhere and attach the bridge to itself. There are a > bunch of examples of this in bridge/ That's not possible at present - this driver has to remain compatible with Armada and TI LCDC, both of which expect this driver to create the encoder. In any case, bridges are buggy with unbinding/rebinding as I've pointed out several times in the past, but TDA998x used with Armada and TI LCDC as it currently stands are not. So, to do this as a full conversion to bridge and pushing the encoders into the DRM drivers results in a regression for these two DRM drivers. I'm not willing to accept such a regression, sorry. Thanks for the other cleanup suggestions, they can be done with a later patch (these changes have already been been merged.) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v2 4/7] drm/i2c: tda998x: convert to bridge driver Date: Wed, 8 Aug 2018 23:15:47 +0100 Message-ID: <20180808221547.GN30658@n2100.armlinux.org.uk> References: <20180730164137.GD17271@n2100.armlinux.org.uk> <20180808190930.GQ20303@art_vandelay> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180808190930.GQ20303@art_vandelay> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sean Paul Cc: Archit Taneja , David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Andrzej Hajda , Tomi Valkeinen , Jyri Sarha , Peter Rosin , linux-arm-kernel@lists.infradead.org, Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org On Wed, Aug 08, 2018 at 03:09:30PM -0400, Sean Paul wrote: > > -static const struct drm_encoder_helper_funcs tda998x_encoder_helper_funcs = { > > - .dpms = tda998x_encoder_dpms, > > - .prepare = tda998x_encoder_prepare, > > - .commit = tda998x_encoder_commit, > > - .mode_set = tda998x_encoder_mode_set, > > -}; > > Now that encoder is a stub, it should really be removed from here. The encoder > should be instantiated elsewhere and attach the bridge to itself. There are a > bunch of examples of this in bridge/ That's not possible at present - this driver has to remain compatible with Armada and TI LCDC, both of which expect this driver to create the encoder. In any case, bridges are buggy with unbinding/rebinding as I've pointed out several times in the past, but TDA998x used with Armada and TI LCDC as it currently stands are not. So, to do this as a full conversion to bridge and pushing the encoders into the DRM drivers results in a regression for these two DRM drivers. I'm not willing to accept such a regression, sorry. Thanks for the other cleanup suggestions, they can be done with a later patch (these changes have already been been merged.) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up