All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>,
	Alberto Garcia <berto@igalia.com>
Subject: [Qemu-devel] [PATCH for-3.1 v10 30/31] block: BDS options may lack the "driver" option
Date: Thu,  9 Aug 2018 23:35:27 +0200	[thread overview]
Message-ID: <20180809213528.14738-31-mreitz@redhat.com> (raw)
In-Reply-To: <20180809213528.14738-1-mreitz@redhat.com>

When BDSs are created by qemu itself (e.g. as filters in block jobs),
they may not have a "driver" option in their options QDict.  When
generating a json:{} filename, however, it must always be present.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/block.c b/block.c
index c4aec7ea65..5118d992c3 100644
--- a/block.c
+++ b/block.c
@@ -5242,6 +5242,12 @@ static bool append_strong_runtime_options(QDict *d, BlockDriverState *bs)
         }
     }
 
+    if (!qdict_haskey(d, "driver")) {
+        /* Drivers created with bdrv_new_open_driver() may not have a
+         * @driver option.  Add it here. */
+        qdict_put_str(d, "driver", bs->drv->format_name);
+    }
+
     return found_any;
 }
 
-- 
2.17.1

  parent reply	other threads:[~2018-08-09 21:36 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 21:34 [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues Max Reitz
2018-08-09 21:34 ` [Qemu-devel] [PATCH for-3.1 v10 01/31] block: Use bdrv_refresh_filename() to pull Max Reitz
2018-08-28 12:13   ` Alberto Garcia
2018-08-09 21:34 ` [Qemu-devel] [PATCH for-3.1 v10 02/31] block: Use children list in bdrv_refresh_filename Max Reitz
2018-08-16 19:02   ` Eric Blake
2018-08-28 12:27   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 03/31] block: Skip implicit nodes for filename info Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 04/31] block: Add BDS.auto_backing_file Max Reitz
2018-09-05 14:22   ` Alberto Garcia
2018-09-07 11:32     ` Max Reitz
2018-09-07 12:28       ` Alberto Garcia
2018-09-07 12:42         ` Max Reitz
2018-09-10 16:17           ` Alberto Garcia
2018-09-11  8:45   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 05/31] block: Respect backing bs in bdrv_refresh_filename Max Reitz
2018-08-28 13:26   ` Alberto Garcia
2018-08-29  9:44     ` Max Reitz
2018-09-04 14:07       ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 06/31] iotests.py: Add filter_imgfmt() Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 07/31] iotests.py: Add node_info() Max Reitz
2018-08-28 12:48   ` Alberto Garcia
2018-08-29  9:45     ` Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 08/31] iotests: Add test for backing file overrides Max Reitz
2018-09-05 14:38   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 09/31] block: Make path_combine() return the path Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 11/31] block: bdrv_get_full_backing_filename's " Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 12/31] block: Add bdrv_make_absolute_filename() Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 13/31] block: Fix bdrv_find_backing_image() Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 14/31] block: Add bdrv_dirname() Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 15/31] blkverify: Make bdrv_dirname() return NULL Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 16/31] quorum: " Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 17/31] block/nbd: " Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 18/31] block/nfs: Implement bdrv_dirname() Max Reitz
2018-08-28 12:49   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 19/31] block: Use bdrv_dirname() for relative filenames Max Reitz
2018-08-28 13:45   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 20/31] iotests: Add quorum case to test 110 Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 21/31] block: Add strong_runtime_opts to BlockDriver Max Reitz
2018-08-28 14:43   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 22/31] block: Add BlockDriver.bdrv_gather_child_options Max Reitz
2018-09-05 12:42   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 23/31] block: Generically refresh runtime options Max Reitz
2018-09-05 12:46   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 24/31] block: Purify .bdrv_refresh_filename() Max Reitz
2018-09-05 12:49   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 25/31] block: Do not copy exact_filename from format file Max Reitz
2018-09-05 13:23   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 26/31] block/nvme: Fix bdrv_refresh_filename() Max Reitz
2018-08-28 13:50   ` Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 27/31] block/curl: Harmonize option defaults Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 28/31] block/curl: Implement bdrv_refresh_filename() Max Reitz
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 29/31] block/null: Generate filename even with latency-ns Max Reitz
2018-08-28 13:33   ` Alberto Garcia
2018-08-29  9:46     ` Max Reitz
2018-08-09 21:35 ` Max Reitz [this message]
2018-08-28 14:44   ` [Qemu-devel] [PATCH for-3.1 v10 30/31] block: BDS options may lack the "driver" option Alberto Garcia
2018-08-09 21:35 ` [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs Max Reitz
2018-09-05 14:44   ` Alberto Garcia
2018-09-07 11:37     ` Max Reitz
2018-08-15  3:43 ` [Qemu-devel] [PATCH for-3.1 v10 00/31] block: Fix some filename generation issues no-reply
2018-08-16  0:01   ` Max Reitz
2018-08-16  6:02     ` Markus Armbruster
2018-08-17 20:03       ` Max Reitz
2018-09-10 15:18 ` Kevin Wolf
2018-09-10 16:51   ` Max Reitz
2018-09-11  9:10     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809213528.14738-31-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=berto@igalia.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.