All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [2018.02.x 1/2] makedevs: allow leading whitespace for capabilities
Date: Thu, 9 Aug 2018 23:42:35 +0200	[thread overview]
Message-ID: <20180809234235.47a45e5f@windsurf> (raw)
In-Reply-To: <20180806031715.7088-1-ricardo.martincoski@gmail.com>

Hello Ricardo,

On Mon,  6 Aug 2018 00:17:14 -0300, Ricardo Martincoski wrote:
> Currently makedevs silently ignores extended attributes with leading
> whitespace, for example those added to a <PACKAGE>_PERMISSIONS following
> the recommended style from check-package.
> 
> Makedevs already ignores leading whitespace for normal entries (file
> permission changes and device files creation). Do the same for extended
> attributes.
> 
> Fixes: #11191.
> 
> Reported-by: Jean-pierre Cartal <jpcartal@free.fr>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

It is not clear to me why you have the "2018.02.x" prefix in your patch
title. I would assume this patch is needed in master, not just in
2018.02.x. We generally include 2018.02.x in the patch title when
the patch should only be applied to 2018.02.x. For patches going in
master, and needing a backport, we normally rely on Peter being smart
and realizing that the patch is a fix that makes sense for 2018.02.x.

Could you clarify what was your intention with this 2018.02.x prefix ?

Perhaps we need to have some tags ?

Backport-to: 2018.02.x

when the patch is for master, but needs to be backported. And perhaps:

Apply-to: 2018.02.x

when the patch is to be applied only on 2018.02.x.

Or simply rely on informal notes below the "---" sign ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-08-09 21:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06  3:17 [Buildroot] [2018.02.x 1/2] makedevs: allow leading whitespace for capabilities Ricardo Martincoski
2018-08-06  3:17 ` [Buildroot] [2018.02.x 2/2] support/testing: add test for file capabilities Ricardo Martincoski
2018-08-10  2:21   ` Ricardo Martincoski
2018-08-10  6:32   ` Peter Korsgaard
2018-08-09 21:42 ` Thomas Petazzoni [this message]
2018-08-10  2:18   ` [Buildroot] [2018.02.x 1/2] makedevs: allow leading whitespace for capabilities Ricardo Martincoski
2018-08-10  6:29     ` Peter Korsgaard
2018-08-10  6:28   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180809234235.47a45e5f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.