From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Esben Haabendal <esben.haabendal@gmail.com>
Cc: linux-i2c@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Yuan Yao <yao.yuan@freescale.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Phil Reid <preid@electromag.com.au>,
Lucas Stach <l.stach@pengutronix.de>,
Clemens Gruber <clemens.gruber@pqgruber.com>,
Peter Rosin <peda@axentia.se>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] i2c: imx: Simplify stopped state tracking
Date: Fri, 10 Aug 2018 14:25:11 +0200 [thread overview]
Message-ID: <20180810122511.2xnelcn6tguirfbp@pengutronix.de> (raw)
In-Reply-To: <87zhxuo9o1.fsf@gmail.com>
Hello Esben,
On Fri, Aug 10, 2018 at 11:25:34AM +0200, Esben Haabendal wrote:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> > Currently you have:
> >
> > if (for_busy && (temp & I2SR_IBB)) {
> > i2c_imx->stopped = 0;
> > break;
> > }
> >
> > if (!for_busy && !(temp & I2SR_IBB)) {
> > i2c_imx->stopped = 1;
> > break;
> > }
> >
> > The semantic of this is the same (apart from always updating .stopped)
> > but is imho easier:
> >
> > i2c_imx->stopped = !(temp & I2SR_IBB);
> >
> > if (for_busy != i2c_imx->stopped)
> > break;
>
> Yes, that should work also.
> Shorter, but IMHO a bit more convoluted to read.
> Let me know if I should send a new version with this change.
unless someone else chimes in I'd say keep it as is. I'd prefer my
variant, but I accept that this is something subjective.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-08-10 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 9:43 [PATCH v2 0/4] i2c: imx: Fix and enable DMA support for LS1021A Esben Haabendal
2018-07-09 9:43 ` [PATCH v2 1/4] i2c: imx: Fix reinit_completion() use Esben Haabendal
2018-07-23 18:08 ` Wolfram Sang
2018-07-09 9:43 ` [PATCH v2 2/4] i2c: imx: Fix race condition in dma read Esben Haabendal
2018-07-24 7:57 ` Uwe Kleine-König
2018-08-09 11:57 ` Esben Haabendal
2018-07-09 9:43 ` [PATCH v2 3/4] i2c: imx: Simplify stopped state tracking Esben Haabendal
2018-07-24 7:59 ` Uwe Kleine-König
2018-08-09 12:06 ` Esben Haabendal
2018-08-09 16:26 ` Uwe Kleine-König
2018-08-10 9:25 ` Esben Haabendal
2018-08-10 12:25 ` Uwe Kleine-König [this message]
2018-07-09 9:43 ` [PATCH v2 4/4] arm: dts: ls1021a: Enable I2C DMA support Esben Haabendal
2018-07-24 8:02 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180810122511.2xnelcn6tguirfbp@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=clemens.gruber@pqgruber.com \
--cc=esben.haabendal@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.