From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v2 12/12] xen/domain: Allocate d->vcpu[] in domain_create() Date: Tue, 14 Aug 2018 17:17:22 +0200 Message-ID: <20180814151722.27m5kt3iec5rfe67@mac> References: <1534154469-6076-1-git-send-email-andrew.cooper3@citrix.com> <1534154469-6076-13-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1534154469-6076-13-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Julien Grall , Stefano Stabellini , Wei Liu , Jan Beulich , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBBdWcgMTMsIDIwMTggYXQgMTE6MDE6MDlBTSArMDEwMCwgQW5kcmV3IENvb3BlciB3 cm90ZToKPiBGb3IgQVJNLCB0aGUgY2FsbCB0byBhcmNoX2RvbWFpbl9jcmVhdGUoKSBuZWVkcyB0 byBoYXZlIGNvbXBsZXRlZCBiZWZvcmUKPiBkb21haW5fbWF4X3ZjcHVzKCkgd2lsbCByZXR1cm4g dGhlIGNvcnJlY3QgdXBwZXIgYm91bmQuCj4gCj4gRm9yIGVhY2ggYXJjaCdzIGRvbTAncywgZHJv cCB0aGUgdGVtcG9yYXJ5IG1heF92Y3B1cyBwYXJhbWV0ZXIsIGFuZCBhbGxvY2F0aW9uCj4gb2Yg ZG9tMC0+dmNwdS4KPiAKPiBXaXRoIGQtPm1heF92Y3B1cyBub3cgY29ycmVjdGx5IGNvbmZpZ3Vy ZWQgYmVmb3JlIGV2dGNobl9pbml0KCksIHRoZSBwb2xsIG1hc2sKPiBjYW4gYmUgY29uc3RydWN0 ZWQgc3VpdGFibHkgZm9yIHRoZSBkb21haW4sIHJhdGhlciB0aGFuIGZvciB0aGUgd29yc3QtY2Fz ZQo+IHNldHRpbmcuCj4gCj4gRHVlIHRvIHRoZSBldnRjaG5faW5pdCgpIGZpeGVzLCBpdCBubyBs b25nZXIgY2FsbHMgZG9tYWluX21heF92Y3B1cygpLCBhbmQKPiBBUk0ncyB0d28gaW1wbGVtZW50 YXRpb25zIG9mIHZnaWNfbWF4X3ZjcHVzKCkgbm8gbG9uZ2VyIG5lZWQgd29yayBhcm91bmQgdGhl Cj4gb3V0LW9mLW9yZGVyIGNhbGwuCj4gCj4gRnJvbSB0aGlzIHBvaW50IG9uLCBkLT5tYXhfdmNw dXMgYW5kIGQtPnZjcHVzW10gYXJlIHZhbGlkIGZvciBhbnkgZG9tYWluIHdoaWNoCj4gY2FuIGJl IGxvb2tlZCB1cCBieSBkb21pZC4KPiAKPiBUaGUgWEVOX0RPTUNUTF9tYXhfdmNwdXMgaHlwZXJj YWxsIGlzIG1vZGlmaWVkIHRvIHJlamVjdCBhbnkgY2FsbCBhdHRlbXB0IHdpdGgKPiBtYXggIT0g ZC0+bWF4X3ZjcHVzLCB3aGljaCBkb2VzIG1hdGNoIHRoZSBvbGRlciBzZW1hbnRpY3MgKG5vdCB0 aGF0IGl0IGlzCj4gb2J2aW91cyBmcm9tIHRoZSBjb2RlKS4gIFRoZSBsb2dpYyB0byBhbGxvY2F0 ZSBkLT52Y3B1W10gaXMgZHJvcHBlZCwgYnV0IGF0Cj4gdGhpcyBwb2ludCB0aGUgaHlwZXJjYWxs IHN0aWxsIG5lZWRzIG1ha2luZyB0byBhbGxvY2F0ZSBlYWNoIHZjcHUuCj4gCj4gU2lnbmVkLW9m Zi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPiAtLS0KPiBD QzogSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+IENDOiBTdGVmYW5vIFN0YWJlbGxp bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4gQ0M6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdy YWxsQGFybS5jb20+Cj4gQ0M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+Cj4gCj4gdjI6 Cj4gICogQWxsb2NhdGUgaW4gZG9tYWluX2NyZWF0ZSgpIHJhdGhlciB0aGFuIGFyY2hfZG9tYWlu X2NyZWF0ZSgpLgo+ICAqIFJldGFpbiBkb21haW5fbWF4X3ZjcHVzKCkuCj4gLS0tCj4gIHhlbi9h cmNoL2FybS9kb21haW5fYnVpbGQuYyB8ICA4ICstLS0tLS0tCj4gIHhlbi9hcmNoL2FybS9zZXR1 cC5jICAgICAgICB8ICAyICstCj4gIHhlbi9hcmNoL2FybS92Z2ljLmMgICAgICAgICB8IDExICst LS0tLS0tLS0tCj4gIHhlbi9hcmNoL2FybS92Z2ljL3ZnaWMuYyAgICB8IDIyICstLS0tLS0tLS0t LS0tLS0tLS0tLS0KPiAgeGVuL2FyY2gveDg2L2RvbTBfYnVpbGQuYyAgIHwgIDggKy0tLS0tLS0K PiAgeGVuL2FyY2gveDg2L3NldHVwLmMgICAgICAgIHwgIDIgKy0KPiAgeGVuL2NvbW1vbi9kb21h aW4uYyAgICAgICAgIHwgMTggKysrKysrKysrKysrKysrKysrCj4gIHhlbi9jb21tb24vZG9tY3Rs LmMgICAgICAgICB8IDM5ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ICB4ZW4vY29tbW9uL2V2ZW50X2NoYW5uZWwuYyAgfCAgMyArLS0KPiAgeGVuL2luY2x1ZGUveGVu L2RvbWFpbi5oICAgIHwgIDIgKy0KPiAgMTAgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygr KSwgODggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5f YnVpbGQuYyBiL3hlbi9hcmNoL2FybS9kb21haW5fYnVpbGQuYwo+IGluZGV4IGY0YTEyMjUuLjZm NDVlNTYgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jCj4gKysrIGIv eGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jCj4gQEAgLTcyLDE0ICs3Miw4IEBAIHVuc2lnbmVk IGludCBfX2luaXQgZG9tMF9tYXhfdmNwdXModm9pZCkKPiAgICAgIHJldHVybiBvcHRfZG9tMF9t YXhfdmNwdXM7Cj4gIH0KPiAgCj4gLXN0cnVjdCB2Y3B1ICpfX2luaXQgYWxsb2NfZG9tMF92Y3B1 MChzdHJ1Y3QgZG9tYWluICpkb20wLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgaW50IG1heF92Y3B1cykKPiArc3RydWN0IHZjcHUgKl9faW5pdCBhbGxv Y19kb20wX3ZjcHUwKHN0cnVjdCBkb21haW4gKmRvbTApCj4gIHsKPiAtICAgIGRvbTAtPnZjcHUg PSB4emFsbG9jX2FycmF5KHN0cnVjdCB2Y3B1ICosIG1heF92Y3B1cyk7Cj4gLSAgICBpZiAoICFk b20wLT52Y3B1ICkKPiAtICAgICAgICByZXR1cm4gTlVMTDsKPiAtICAgIGRvbTAtPm1heF92Y3B1 cyA9IG1heF92Y3B1czsKPiAtCj4gICAgICByZXR1cm4gYWxsb2NfdmNwdShkb20wLCAwLCAwKTsK PiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3NldHVwLmMgYi94ZW4vYXJjaC9h cm0vc2V0dXAuYwo+IGluZGV4IDcyZTQyZTguLmEzZTFlZjcgMTAwNjQ0Cj4gLS0tIGEveGVuL2Fy Y2gvYXJtL3NldHVwLmMKPiArKysgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYwo+IEBAIC04NjMsNyAr ODYzLDcgQEAgdm9pZCBfX2luaXQgc3RhcnRfeGVuKHVuc2lnbmVkIGxvbmcgYm9vdF9waHlzX29m ZnNldCwKPiAgICAgIGRvbTBfY2ZnLm1heF92Y3B1cyA9IGRvbTBfbWF4X3ZjcHVzKCk7Cj4gIAo+ ICAgICAgZG9tMCA9IGRvbWFpbl9jcmVhdGUoMCwgJmRvbTBfY2ZnLCB0cnVlKTsKPiAtICAgIGlm ICggSVNfRVJSKGRvbTApIHx8IChhbGxvY19kb20wX3ZjcHUwKGRvbTAsIGRvbTBfY2ZnLm1heF92 Y3B1cykgPT0gTlVMTCkgKQo+ICsgICAgaWYgKCBJU19FUlIoZG9tMCkgfHwgKGFsbG9jX2RvbTBf dmNwdTAoZG9tMCkgPT0gTlVMTCkgKQo+ICAgICAgICAgICAgICBwYW5pYygiRXJyb3IgY3JlYXRp bmcgZG9tYWluIDAiKTsKPiAgCj4gICAgICBpZiAoIGNvbnN0cnVjdF9kb20wKGRvbTApICE9IDAp Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS92Z2ljLmMgYi94ZW4vYXJjaC9hcm0vdmdpYy5j Cj4gaW5kZXggN2EyYzQ1NS4uNWE0ZjA4MiAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC9hcm0vdmdp Yy5jCj4gKysrIGIveGVuL2FyY2gvYXJtL3ZnaWMuYwo+IEBAIC02NjksMTYgKzY2OSw3IEBAIHZv aWQgdmdpY19mcmVlX3ZpcnEoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgaW50IHZpcnEpCj4g IAo+ICB1bnNpZ25lZCBpbnQgdmdpY19tYXhfdmNwdXMoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCkK PiAgewo+IC0gICAgLyoKPiAtICAgICAqIFNpbmNlIGV2dGNobl9pbml0IHdvdWxkIGNhbGwgZG9t YWluX21heF92Y3B1cyBmb3IgcG9sbF9tYXNrCj4gLSAgICAgKiBhbGxvY2F0aW9uIHdoZW4gdGhl IHZnaWNfb3BzIGhhdmVuJ3QgYmVlbiBpbml0aWFsaXNlZCB5ZXQsCj4gLSAgICAgKiB3ZSByZXR1 cm4gTUFYX1ZJUlRfQ1BVUyBpZiBkLT5hcmNoLnZnaWMuaGFuZGxlciBpcyBudWxsLgo+IC0gICAg ICovCj4gLSAgICBpZiAoICFkLT5hcmNoLnZnaWMuaGFuZGxlciApCj4gLSAgICAgICAgcmV0dXJu IE1BWF9WSVJUX0NQVVM7Cj4gLSAgICBlbHNlCj4gLSAgICAgICAgcmV0dXJuIG1pbl90KHVuc2ln bmVkIGludCwgTUFYX1ZJUlRfQ1BVUywKPiAtICAgICAgICAgICAgICAgICAgICAgZC0+YXJjaC52 Z2ljLmhhbmRsZXItPm1heF92Y3B1cyk7Cj4gKyAgICByZXR1cm4gbWluX3QodW5zaWduZWQgaW50 LCBNQVhfVklSVF9DUFVTLCBkLT5hcmNoLnZnaWMuaGFuZGxlci0+bWF4X3ZjcHVzKTsKPiAgfQo+ ICAKPiAgLyoKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3ZnaWMvdmdpYy5jIGIveGVuL2Fy Y2gvYXJtL3ZnaWMvdmdpYy5jCj4gaW5kZXggODMyNjMyYS4uNDEyNDgxNyAxMDA2NDQKPiAtLS0g YS94ZW4vYXJjaC9hcm0vdmdpYy92Z2ljLmMKPiArKysgYi94ZW4vYXJjaC9hcm0vdmdpYy92Z2lj LmMKPiBAQCAtOTUxLDI3ICs5NTEsNyBAQCB2b2lkIHZnaWNfc3luY19oYXJkd2FyZV9pcnEoc3Ry dWN0IGRvbWFpbiAqZCwKPiAgCj4gIHVuc2lnbmVkIGludCB2Z2ljX21heF92Y3B1cyhjb25zdCBz dHJ1Y3QgZG9tYWluICpkKQo+ICB7Cj4gLSAgICB1bnNpZ25lZCBpbnQgdmdpY192Y3B1X2xpbWl0 Owo+IC0KPiAtICAgIHN3aXRjaCAoIGQtPmFyY2gudmdpYy52ZXJzaW9uICkKPiAtICAgIHsKPiAt ICAgIGNhc2UgR0lDX0lOVkFMSUQ6Cj4gLSAgICAgICAgLyoKPiAtICAgICAgICAgKiBTaW5jZSBl dnRjaG5faW5pdCB3b3VsZCBjYWxsIGRvbWFpbl9tYXhfdmNwdXMgZm9yIHBvbGxfbWFzawo+IC0g ICAgICAgICAqIGFsbG9jYXRpb24gYmVmb3JlIHRoZSBWR0lDIGhhcyBiZWVuIGluaXRpYWxpc2Vk LCB3ZSBuZWVkIHRvCj4gLSAgICAgICAgICogcmV0dXJuIHNvbWUgc2FmZSB2YWx1ZSBpbiB0aGlz IGNhc2UuIEFzIHRoaXMgaXMgZm9yIGFsbG9jYXRpb24KPiAtICAgICAgICAgKiBwdXJwb3Nlcywg Z28gd2l0aCB0aGUgbWF4aW11bSB2YWx1ZS4KPiAtICAgICAgICAgKi8KPiAtICAgICAgICB2Z2lj X3ZjcHVfbGltaXQgPSBNQVhfVklSVF9DUFVTOwo+IC0gICAgICAgIGJyZWFrOwo+IC0gICAgY2Fz ZSBHSUNfVjI6Cj4gLSAgICAgICAgdmdpY192Y3B1X2xpbWl0ID0gVkdJQ19WMl9NQVhfQ1BVUzsK PiAtICAgICAgICBicmVhazsKPiAtICAgIGRlZmF1bHQ6Cj4gLSAgICAgICAgQlVHKCk7Cj4gLSAg ICB9Cj4gLQo+IC0gICAgcmV0dXJuIG1pbl90KHVuc2lnbmVkIGludCwgTUFYX1ZJUlRfQ1BVUywg dmdpY192Y3B1X2xpbWl0KTsKPiArICAgIHJldHVybiBtaW5fdCh1bnNpZ25lZCBpbnQsIE1BWF9W SVJUX0NQVVMsIGQtPmFyY2gudmdpYy5oYW5kbGVyLT5tYXhfdmNwdXMpOwo+ICB9CgpTaW5jZSBi b3RoIGltcGxlbWVudGF0aW9ucyBhcmUgZXF1YWwgbm93LCBjYW4geW91IHBsYWNlIHRoaXMgaW4g dmdpYy5oCmFzIGEgc3RhdGljIGlubGluZSBmdW5jdGlvbj8KCldpdGggdGhhdDoKClJldmlld2Vk LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxp c3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVj dC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=