All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Rob Herring <robh@kernel.org>
Cc: Biju Das <biju.das@bp.renesas.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Takeshi Kihara <takeshi.kihara.df@renesas.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	devicetree@vger.kernel.org,
	"open list:MEDIA DRIVERS FOR RENESAS - FCP"
	<linux-renesas-soc@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH v2 2/5] soc: renesas: rcar-sysc: Add r8a774a1 support
Date: Fri, 17 Aug 2018 10:46:40 +0200	[thread overview]
Message-ID: <20180817084639.kp2kasqsl676ejsb@verge.net.au> (raw)
In-Reply-To: <CAL_JsqJZiypRkwKJPBYUR-FOyMJLiM0qKdt9LK1QEHgQ1Vp6Mw@mail.gmail.com>

On Fri, Aug 10, 2018 at 09:50:15AM -0600, Rob Herring wrote:
> On Fri, Aug 10, 2018 at 5:13 AM Simon Horman <horms@verge.net.au> wrote:
> >
> > On Fri, Aug 10, 2018 at 07:37:18AM +0000, Biju Das wrote:
> > > Hi Rob,
> > >
> > > > Subject: Re: [PATCH v2 2/5] soc: renesas: rcar-sysc: Add r8a774a1 support
> > > >
> > > > Hi, this is an automated email from Rob's (experimental) review bot. I found
> > > > a couple of common problems with your patch. Please see below.
> > >
> > > Do I need to send another patch? The mail says " Rob's (experimental)
> > > review bot".  Previously for RZ/G1C upstreaming I have submitted the
> > > patches in similar fashion.  Is anything changed?
> >
> > Yes, indeed.
> >
> > At one point I was enforcing such a split but as it did not seem to be a
> > universal practice I stopped doing so.  I'd like some clear guidance from
> > Rob if he'd like this split to occur going forwards.
> 
> I've generally not asked for either of these on 1 (or few) line
> changes or if I had no other comments on the patch. But for automated
> checking I'm not going to try to make that distinction. So, still up
> to whomever applies them.
> 
> BTW, I'm adding the splitting patches check to checkpatch.pl too.

Thanks, it sounds to me that splitting things will be the cleanest
approach for future patches. We'll see how that goes.

      reply	other threads:[~2018-08-17  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 14:53 [PATCH v2 2/5] soc: renesas: rcar-sysc: Add r8a774a1 support Biju Das
2018-08-09 11:10 ` Simon Horman
     [not found] ` <5b6cc303.1c69fb81.26116.320b@mx.google.com>
2018-08-10  7:37   ` Biju Das
2018-08-10 11:13     ` Simon Horman
2018-08-10 15:50       ` Rob Herring
2018-08-17  8:46         ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817084639.kp2kasqsl676ejsb@verge.net.au \
    --to=horms@verge.net.au \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=takeshi.kihara.df@renesas.com \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.