From: Frederic Weisbecker <frederic@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Milind Chabbi <chabbi.milind@gmail.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0
Date: Fri, 17 Aug 2018 16:47:28 +0200 [thread overview]
Message-ID: <20180817144727.GC12426@lerouge> (raw)
In-Reply-To: <20180810104730.3293-4-jolsa@kernel.org>
On Fri, Aug 10, 2018 at 12:47:28PM +0200, Jiri Olsa wrote:
> Once the breakpoint was succesfully modified, the attr->disabled
> value is in bp->attr.disabled. So there's no reason to set it
> again, removing that.
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
> Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucuxkp0@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Frederic Weisbecker <frederic@kernel.org>
next prev parent reply other threads:[~2018-08-17 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 10:47 [PATCHv3 0/5] perf/hw_breakpoint: Fix breakpoint modify Jiri Olsa
2018-08-10 10:47 ` [PATCH 1/5] perf tests: Add breakpoint modify tests Jiri Olsa
2018-08-10 10:47 ` [PATCH 2/5] perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set Jiri Olsa
2018-08-17 14:27 ` Frederic Weisbecker
2018-08-10 10:47 ` [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0 Jiri Olsa
2018-08-17 14:47 ` Frederic Weisbecker [this message]
2018-08-10 10:47 ` [PATCH 4/5] perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpoint Jiri Olsa
2018-08-14 10:32 ` Oleg Nesterov
2018-08-17 14:50 ` Frederic Weisbecker
2018-08-10 10:47 ` [PATCH 5/5] perf/hw_breakpoint: Simplify breakpoint enable in perf_event_modify_breakpoint Jiri Olsa
2018-08-14 10:32 ` Oleg Nesterov
2018-08-17 11:48 ` [PATCHv3 0/5] perf/hw_breakpoint: Fix breakpoint modify Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2018-08-27 9:12 [PATCHv4 " Jiri Olsa
2018-08-27 9:12 ` [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0 Jiri Olsa
2018-08-09 12:03 [PATCHv2 0/5] perf/hw_breakpoint: Fix breakpoint modify Jiri Olsa
2018-08-09 12:03 ` [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0 Jiri Olsa
2018-08-09 13:59 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817144727.GC12426@lerouge \
--to=frederic@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=chabbi.milind@gmail.com \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.