From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Cc: <boris.brezillon@bootlin.com>, <richard@nod.at>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<marek.vasut@gmail.com>, <kyungmin.park@samsung.com>,
<absahu@codeaurora.org>, <peterpandong@micron.com>,
<frieder.schrempf@exceet.de>, <linux-mtd@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <michals@xilinx.com>,
<nagasureshkumarrelli@gmail.com>
Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller
Date: Fri, 17 Aug 2018 16:37:33 +0200 [thread overview]
Message-ID: <20180817163733.34d3199c@xps13> (raw)
In-Reply-To: <1534511964-20342-3-git-send-email-naga.sureshkumar.relli@xilinx.com>
Hi Naga,
A user of Xilinx BSP reported a problem with lockdep that I can see is
not yet fixed in this code:
Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote on
Fri, 17 Aug 2018 18:49:24 +0530:
> +static int anfc_probe(struct platform_device *pdev)
> +{
> + struct anfc_nand_controller *nfc;
> + struct anfc_nand_chip *anand_chip;
> + struct device_node *np = pdev->dev.of_node, *child;
> + struct resource *res;
> + int err;
> +
> + nfc = devm_kzalloc(&pdev->dev, sizeof(*nfc), GFP_KERNEL);
> + if (!nfc)
> + return -ENOMEM;
> +
> + init_waitqueue_head(&nfc->controller.wq);
The controller structure has a lock which is not initialized here. You
should not initialize the waitqueue manually neither and instead use
nand_controller_init(&nfc->controller).
> + INIT_LIST_HEAD(&nfc->chips);
> + init_completion(&nfc->event);
> + nfc->dev = &pdev->dev;
> + platform_set_drvdata(pdev, nfc);
> + nfc->csnum = -1;
> + nfc->controller.ops = &anfc_nand_controller_ops;
More to come.
Thanks,
Miquèl
next prev parent reply other threads:[~2018-08-17 14:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 13:19 [LINUX PATCH v10 0/2] Add support for Arasan NAND Flash controller Naga Sureshkumar Relli
2018-08-17 13:19 ` [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation Naga Sureshkumar Relli
2018-08-20 12:33 ` Boris Brezillon
2018-08-21 5:47 ` Naga Sureshkumar Relli
2018-08-21 5:59 ` Boris Brezillon
2018-08-21 9:22 ` Naga Sureshkumar Relli
2018-08-21 9:52 ` Miquel Raynal
2018-08-21 10:44 ` Naga Sureshkumar Relli
2018-08-21 10:52 ` Boris Brezillon
2018-08-21 11:10 ` Boris Brezillon
2018-08-17 13:19 ` [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Naga Sureshkumar Relli
2018-08-17 14:37 ` Miquel Raynal [this message]
2018-08-18 4:48 ` Naga Sureshkumar Relli
2018-08-17 15:30 ` kbuild test robot
2018-08-17 17:59 ` Boris Brezillon
2018-08-18 5:49 ` Naga Sureshkumar Relli
2018-08-20 8:53 ` Boris Brezillon
2018-08-20 10:49 ` Naga Sureshkumar Relli
2018-08-20 12:10 ` Boris Brezillon
2018-08-20 12:21 ` Naga Sureshkumar Relli
2018-08-20 12:24 ` Boris Brezillon
2018-08-20 16:40 ` Boris Brezillon
2018-08-21 6:40 ` Naga Sureshkumar Relli
2018-08-21 7:31 ` Miquel Raynal
2018-09-11 5:23 ` Naga Sureshkumar Relli
2018-09-22 7:53 ` Miquel Raynal
2018-09-22 8:13 ` Boris Brezillon
2018-09-24 8:42 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817163733.34d3199c@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=absahu@codeaurora.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@exceet.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=michals@xilinx.com \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=nagasureshkumarrelli@gmail.com \
--cc=peterpandong@micron.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.