From: Omar Sandoval <osandov@osandov.com>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] block: remove duplicate initialization
Date: Fri, 17 Aug 2018 11:09:35 -0700 [thread overview]
Message-ID: <20180817180935.GC22101@vader> (raw)
In-Reply-To: <20180816224529.3401-1-chaitanya.kulkarni@wdc.com>
On Thu, Aug 16, 2018 at 03:45:29PM -0700, Chaitanya Kulkarni wrote:
> This patch removes the duplicate initialization of q->queue_head
> in the blk_alloc_queue_node(). This removes the 2nd initialization
> so that we preserve the initialization order same as declaration
> present in struct request_queue.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> block/blk-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 21c7cb35d3b4..dee56c282efb 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1036,7 +1036,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id,
> laptop_mode_timer_fn, 0);
> timer_setup(&q->timeout, blk_rq_timed_out_timer, 0);
> INIT_WORK(&q->timeout_work, NULL);
> - INIT_LIST_HEAD(&q->queue_head);
> INIT_LIST_HEAD(&q->timeout_list);
> INIT_LIST_HEAD(&q->icq_list);
> #ifdef CONFIG_BLK_CGROUP
> --
> 2.17.0
>
next prev parent reply other threads:[~2018-08-17 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 22:45 [PATCH] block: remove duplicate initialization Chaitanya Kulkarni
2018-08-17 18:09 ` Omar Sandoval [this message]
2018-08-17 18:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817180935.GC22101@vader \
--to=osandov@osandov.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.