From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ahmad Fatoum Subject: [PATCH 2/4] of: phy: Warn about unexpected fixed-links in of_mdiobus_register Date: Mon, 20 Aug 2018 14:12:36 +0200 Message-ID: <20180820121238.7779-2-a.fatoum@pengutronix.de> References: <20180820121238.7779-1-a.fatoum@pengutronix.de> Cc: kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org, Brad Mouring , Florian Fainelli To: Andrew Lunn , "David S. Miller" , Nicolas Ferre Return-path: Received: from metis.ext.pengutronix.de ([85.220.165.71]:46613 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbeHTP2X (ORCPT ); Mon, 20 Aug 2018 11:28:23 -0400 In-Reply-To: <20180820121238.7779-1-a.fatoum@pengutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: fixed-links are currently not handled by of_mdiobus_register, skip them with a warning instead of trying pointlessly to find their PHY address: libphy: MACB_mii_bus: probed mdio_bus f0028000.ethernet-ffffffff: fixed-link has invalid PHY address mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 0 [snip] mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 31 macb f0028000.ethernet: broken fixed-link specification Signed-off-by: Ahmad Fatoum --- drivers/of/of_mdio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index e92391d6d1bd..9a7ccd299daf 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -229,6 +229,13 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) /* Loop over the child nodes and register a phy_device for each phy */ for_each_available_child_of_node(np, child) { + if (of_phy_is_fixed_link(np)) { + /* fixed-links are handled in the MAC drivers */ + dev_warn(&mdio->dev, FW_BUG + "Skipping unexpected fixed-link in device tree"); + continue; + } + addr = of_mdio_parse_addr(&mdio->dev, child); if (addr < 0) { scanphys = true; -- 2.18.0