From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/4] net: macb: Fix regression breaking non-MDIO fixed-link PHYs Date: Tue, 21 Aug 2018 15:34:44 +0200 Message-ID: <20180821133444.GB2985@lunn.ch> References: <20180820121238.7779-1-a.fatoum@pengutronix.de> <20180820135536.GD6583@lunn.ch> <20180820190630.GB12238@lunn.ch> <77901074-bb78-5860-d6bc-00a1826de8a6@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Nicolas Ferre , kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org, Brad Mouring , Florian Fainelli To: Ahmad Fatoum Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:40113 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727148AbeHUQzD (ORCPT ); Tue, 21 Aug 2018 12:55:03 -0400 Content-Disposition: inline In-Reply-To: <77901074-bb78-5860-d6bc-00a1826de8a6@pengutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: > I've traced it some more: While mdiobus_register fails to find a PHY, > creation of the "MDIO" bus is still successful and it returns successfully, > having claimed the reset GPIO. > > of_phy_fixed_link_register tries to claim the same GPIO and fails. I don't see where this is happening. It is looking for a gpio called 'link-gpios'. > But regardless, there shouldn't have been an of_mdiobus_register and a MDIO bus probe > before registering the fixed-link in the first place and my patch remedies that. There are cases where you need both, e.g a switch controller over MDIO. So we cannot make it one or the other. However, there are currently no such boards. So far "net", lets go with your partial revert patch. But we also need patches for "net-next" which put it back again, allows both fixed-link and an mdiobus inside a subnode, and not break backwards compatibility. Andrew