From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 01/11] telemetry: initial telemetry
 infrastructure
Date: Thu, 23 Aug 2018 16:17:06 -0700
Message-ID: <20180823161706.601ffde5@xeon-e3>
References: <1535026093-101872-1-git-send-email-ciara.power@intel.com>
 <1535026093-101872-2-git-send-email-ciara.power@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: harry.van.haaren@intel.com, brian.archbold@intel.com,
 emma.kenny@intel.com, dev@dpdk.org
To: Ciara Power <ciara.power@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
 [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 3148A2C60
 for <dev@dpdk.org>; Fri, 24 Aug 2018 01:17:09 +0200 (CEST)
Received: by mail-pg1-f194.google.com with SMTP id b129-v6so3366227pga.13
 for <dev@dpdk.org>; Thu, 23 Aug 2018 16:17:09 -0700 (PDT)
In-Reply-To: <1535026093-101872-2-git-send-email-ciara.power@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 23 Aug 2018 13:08:03 +0100
Ciara Power <ciara.power@intel.com> wrote:

> +
> +static int
> +telemetry_probe(struct rte_vdev_device *vdev)
> +{
> +	int ret;
> +
> +	RTE_SET_USED(vdev);
> +	ret = rte_telemetry_init(rte_socket_id());
> +	if (ret < 0) {
> +		printf("Error - Telemetry initialisation failed\n");
> +		return -1;
> +	}
> +	return 0;
> +}
> +
> +static int
> +telemetry_remove(struct rte_vdev_device *vdev)
> +{
> +	const char *name;
> +	name = rte_vdev_device_name(vdev);
> +	printf("Uninitialising the device: %s\n", name);

Please use DPDK (rte) logging for all messages.