From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 01/11] telemetry: initial telemetry
 infrastructure
Date: Thu, 23 Aug 2018 16:18:55 -0700
Message-ID: <20180823161855.67747b25@xeon-e3>
References: <1535026093-101872-1-git-send-email-ciara.power@intel.com>
 <1535026093-101872-2-git-send-email-ciara.power@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: harry.van.haaren@intel.com, brian.archbold@intel.com,
 emma.kenny@intel.com, dev@dpdk.org
To: Ciara Power <ciara.power@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com
 [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id 7F5BF98
 for <dev@dpdk.org>; Fri, 24 Aug 2018 01:18:57 +0200 (CEST)
Received: by mail-pf1-f172.google.com with SMTP id d4-v6so3593037pfn.0
 for <dev@dpdk.org>; Thu, 23 Aug 2018 16:18:57 -0700 (PDT)
In-Reply-To: <1535026093-101872-2-git-send-email-ciara.power@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 23 Aug 2018 13:08:03 +0100
Ciara Power <ciara.power@intel.com> wrote:

> +			TELEMETRY_LOG_ERR("Error - Calling thread could not be"
> +				" put to sleep\n");

Don't break strings across lines. It makes it harder for developers who want
to use tools to look for log message in source.  Checkpatch and friends allow for long
line exception for string literals.