From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 01/11] telemetry: initial telemetry
 infrastructure
Date: Thu, 23 Aug 2018 16:22:22 -0700
Message-ID: <20180823162222.49445f97@xeon-e3>
References: <1535026093-101872-1-git-send-email-ciara.power@intel.com>
 <1535026093-101872-2-git-send-email-ciara.power@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: harry.van.haaren@intel.com, brian.archbold@intel.com,
 emma.kenny@intel.com, dev@dpdk.org
To: Ciara Power <ciara.power@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com
 [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 647EC98
 for <dev@dpdk.org>; Fri, 24 Aug 2018 01:22:25 +0200 (CEST)
Received: by mail-pf1-f193.google.com with SMTP id h79-v6so2706506pfk.8
 for <dev@dpdk.org>; Thu, 23 Aug 2018 16:22:25 -0700 (PDT)
In-Reply-To: <1535026093-101872-2-git-send-email-ciara.power@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 23 Aug 2018 13:08:03 +0100
Ciara Power <ciara.power@intel.com> wrote:

> +/* Logging Macros */
> +extern int telemetry_log_level;
> +
> +#define TELEMETRY_LOG(level, fmt, args...) \
> +	rte_log(RTE_LOG_ ##level, telemetry_log_level, "%s(): "fmt "\n", \
> +		__func__, ##args)
> +
> +#define TELEMETRY_LOG_ERR(fmt, args...) \
> +	TELEMETRY_LOG(ERR, fmt, ## args)
> +
> +#define TELEMETRY_LOG_WARN(fmt, args...) \
> +	TELEMETRY_LOG(WARNING, fmt, ## args)
> +
> +#define TELEMETRY_LOG_INFO(fmt, args...) \
> +	TELEMETRY_LOG(INFO, fmt, ## args)
> +
> +typedef struct telemetry_impl {
> +	pthread_t thread_id;
> +	int thread_status;
> +	uint32_t socket_id;
> +} telemetry_impl;
> +

Your logging macros follow the standard DPDK style. Including automatically
adding a new line. But as I look at the code, many of the TELEMETRY_LOG calls
have a newline in the format. Therefore your log messages will be double spaced.