From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B0DC433F4 for ; Tue, 28 Aug 2018 08:36:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D37802087C for ; Tue, 28 Aug 2018 08:36:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D37802087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727552AbeH1M0z (ORCPT ); Tue, 28 Aug 2018 08:26:55 -0400 Received: from mga01.intel.com ([192.55.52.88]:48110 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727519AbeH1M0y (ORCPT ); Tue, 28 Aug 2018 08:26:54 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 01:36:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,298,1531810800"; d="scan'208";a="66541810" Received: from jsakkine-mobl1.fi.intel.com (HELO localhost) ([10.237.66.39]) by fmsmga008.fm.intel.com with ESMTP; 28 Aug 2018 01:36:15 -0700 Date: Tue, 28 Aug 2018 11:36:15 +0300 From: Jarkko Sakkinen To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Suresh Siddha , Serge Ayoun , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Message-ID: <20180828083615.GI15508@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <40632d90-8222-e31a-4729-22b89ed52a8d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40632d90-8222-e31a-4729-22b89ed52a8d@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2018 at 02:14:24PM -0700, Dave Hansen wrote: > On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > > +enum sgx_alloc_flags { > > + SGX_ALLOC_ATOMIC = BIT(0), > > +}; > > Doing this with enums is unprecedented IMNHO. Why are you doing it this > way for simple, one-off constants? I'll change it to bool, thanks. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 28 Aug 2018 11:36:15 +0300 From: Jarkko Sakkinen To: Dave Hansen CC: , , , , , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Suresh Siddha , Serge Ayoun , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Message-ID: <20180828083615.GI15508@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <40632d90-8222-e31a-4729-22b89ed52a8d@intel.com> Content-Type: text/plain; charset="us-ascii" In-Reply-To: <40632d90-8222-e31a-4729-22b89ed52a8d@intel.com> Return-Path: jarkko.sakkinen@linux.intel.com MIME-Version: 1.0 List-ID: On Mon, Aug 27, 2018 at 02:14:24PM -0700, Dave Hansen wrote: > On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > > +enum sgx_alloc_flags { > > + SGX_ALLOC_ATOMIC = BIT(0), > > +}; > > Doing this with enums is unprecedented IMNHO. Why are you doing it this > way for simple, one-off constants? I'll change it to bool, thanks. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Date: Tue, 28 Aug 2018 11:36:15 +0300 Message-ID: <20180828083615.GI15508@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <40632d90-8222-e31a-4729-22b89ed52a8d@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <40632d90-8222-e31a-4729-22b89ed52a8d@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Suresh Siddha , Serge Ayoun , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" List-Id: platform-driver-x86.vger.kernel.org On Mon, Aug 27, 2018 at 02:14:24PM -0700, Dave Hansen wrote: > On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > > +enum sgx_alloc_flags { > > + SGX_ALLOC_ATOMIC = BIT(0), > > +}; > > Doing this with enums is unprecedented IMNHO. Why are you doing it this > way for simple, one-off constants? I'll change it to bool, thanks. /Jarkko