From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=TO5I=LL=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 11A08C433F4
	for <linux-kernel@archiver.kernel.org>; Tue, 28 Aug 2018 14:29:20 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B1CD52087B
	for <linux-kernel@archiver.kernel.org>; Tue, 28 Aug 2018 14:29:19 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OD+x1tqK"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1CD52087B
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727970AbeH1SVM (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 28 Aug 2018 14:21:12 -0400
Received: from mail.kernel.org ([198.145.29.99]:51216 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726120AbeH1SVM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Aug 2018 14:21:12 -0400
Received: from jouet.infradead.org (unknown [190.15.121.82])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 05F2320878;
        Tue, 28 Aug 2018 14:29:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1535466557;
        bh=yc0JtcnKqyKUdlixfzPj8LUyalOs5NF9/RFkqGh6HC8=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=OD+x1tqK0JogLcMtAQgepMoS806dylDgKs1+i7ipCLNPHuwiIvRgUKq7idOPSU9Mc
         ML9SwKA/gs+1ZwKXuW9xREcgqeay31NiGRFZPbITp29o4mEsq6pQYI55P6NkjxVhsw
         L2uKgBx6zfPEVV7IKx4x2Brzb+W/6uSYfs5Unr0k=
Received: by jouet.infradead.org (Postfix, from userid 1000)
        id 97C38141C3F; Tue, 28 Aug 2018 11:29:14 -0300 (-03)
Date:   Tue, 28 Aug 2018 11:29:14 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Oleg Nesterov <oleg@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Milind Chabbi <chabbi.milind@gmail.com>,
        Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH 4/5] perf/hw_breakpoint: Set breakpoint as disabled in
 modify_user_hw_breakpoint error path
Message-ID: <20180828142914.GJ22309@kernel.org>
References: <20180809120305.20693-1-jolsa@kernel.org>
 <20180809120305.20693-5-jolsa@kernel.org>
 <20180809141713.GB22636@redhat.com>
 <20180809163015.GA23170@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180809163015.GA23170@krava>
X-Url:  http://acmel.wordpress.com
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Thu, Aug 09, 2018 at 06:30:15PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 09, 2018 at 04:17:13PM +0200, Oleg Nesterov wrote:
> > On 08/09, Jiri Olsa wrote:
> > > -	if (err)
> > > +	if (err) {
> > > +		bp->attr.disabled = 1;
> > >  		return err;
> > 
> > Yes, but on the second thought... Can't we simply do

<SNIP>

> > instead of this and the next patch?

<SNIP>
 
> yep, seems good.. will send new version

Ok, but this is just for 4/5 and 5/5, right?

- Arnaldo