All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Revert "package/aircrack-ng: powerpc arch requires altivec"
Date: Tue, 28 Aug 2018 23:53:20 +0200	[thread overview]
Message-ID: <20180828235320.79831d3a@windsurf.home> (raw)
In-Reply-To: <1535411668-36286-2-git-send-email-matthew.weber@rockwellcollins.com>

Hello,

On Mon, 27 Aug 2018 18:14:28 -0500, Matt Weber wrote:
> This reverts commit 1f3f1fb8c7324c9a50383b1cafcbd2f9d74a91f9.
> 
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---
>  package/aircrack-ng/Config.in | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/package/aircrack-ng/Config.in b/package/aircrack-ng/Config.in
> index d821c5a..f3e2bc4 100644
> --- a/package/aircrack-ng/Config.in
> +++ b/package/aircrack-ng/Config.in
> @@ -4,9 +4,6 @@ config BR2_PACKAGE_AIRCRACK_NG
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on !BR2_STATIC_LIBS # dlfcn.h
> -	# https://github.com/aircrack-ng/aircrack-ng/issues/1941
> -	depends on BR2_POWERPC_CPU_HAS_ALTIVEC || \
> -		!(BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le)

This revert made me realize that the commit itself was wrong: this
architecture dependency had not been propagated to the Config.in
comment in the same file.

But with the revert, this is obviously no longer relevant.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-28 21:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 23:14 [Buildroot] [PATCH 1/2] package/aircrack-ng: powerpc support optional ALTIVEC Matt Weber
2018-08-27 23:14 ` [Buildroot] [PATCH 2/2] Revert "package/aircrack-ng: powerpc arch requires altivec" Matt Weber
2018-08-28 21:53   ` Thomas Petazzoni [this message]
2018-08-28 21:52 ` [Buildroot] [PATCH 1/2] package/aircrack-ng: powerpc support optional ALTIVEC Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828235320.79831d3a@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.