From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:38174 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725799AbeH2EJE (ORCPT ); Wed, 29 Aug 2018 00:09:04 -0400 Received: by mail-pl1-f194.google.com with SMTP id u11-v6so1456970plq.5 for ; Tue, 28 Aug 2018 17:14:58 -0700 (PDT) Date: Tue, 28 Aug 2018 17:14:54 -0700 From: Brian Norris To: Kalle Valo Cc: Arend van Spriel , govinds@codeaurora.org, linux-wireless@vger.kernel.org, Linux Kernel , ath10k@lists.infradead.org Subject: Re: [PATCH] ath10k: retrieve MAC address from firmware if provided Message-ID: <20180829001453.GA173345@ban.mtv.corp.google.com> (sfid-20180829_021500_953999_569127F3) References: <20180810233948.144792-1-briannorris@chromium.org> <5B6F2A47.7070502@broadcom.com> <5B71CDFB.60408@broadcom.com> <878t4qftnm.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <878t4qftnm.fsf@kamboji.qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 28, 2018 at 05:33:01PM +0300, Kalle Valo wrote: > Arend van Spriel writes: > > > On 8/13/2018 7:14 PM, Brian Norris wrote: > >> On Sat, Aug 11, 2018 at 11:26 AM Arend van Spriel > >> wrote: > >>> > >>> On 8/11/2018 1:39 AM, Brian Norris wrote: > >>>> Devices may provide their own MAC address via system firmware (e.g., > >>> > >>> You got me confused by using just "firmware" in the subject. > >> > >> Yeah...I started by writing this patch with device tree specifically > >> (of_get_mac_address()), and then later found that there were generic > >> "device" helpers for this, which can assist with other sorts of > >> firmware nodes. It was easier to put a name on a device tree patch > >> than on a "device" patch. I suppose "system firmware" might be a > >> better description? > >> > >>>> device tree), especially in the case where the device doesn't have a > >>>> useful EEPROM on which to store its MAC address (e.g., for integrated > >>>> Wifi). > >>>> > >>>> Use the generic device helper to retrieve the MAC address, and (if > >>>> present) honor it above the MAC address advertised by the card. > >>> > >>> But this put me back on track ;-) > >> > >> Let me know if you have a better way to clarify. I can resend with a > >> slightly modified subject (s/firmware/system firmware/), or let Kalle > >> do it, if that's the only thing to change. > > > > "system firmware" substitution works for me. > > What about: > > ath10k: retrieve MAC address from Device Tree if provided > > Because from ath10k point of view we use Device Tree functions and don't > care if it's delivered by pidgeons or by system firmware :) I don't care too much, but note that Device Tree is a loaded term, usually referring specifically to a method of describing system hardware via the Flattened Device Tree format. If I were specifically targeting Device Tree, I'd use helpers like of_get_mac_address() instead. (The 'of_*' prefix is a relic of OpenFirmware, an early firmware implementation that used the Device Tree format.) If you're trying to say "device tree" to refer to "the Linux device hierarchy", then that's also a fair description. But that's all starting to mince words. Device Tree (with or without capitalization) is fine with me. Thanks, Brian > I can change this before I commit. > > -- > Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fuo8b-0002aM-E2 for ath10k@lists.infradead.org; Wed, 29 Aug 2018 00:15:11 +0000 Received: by mail-pl1-x642.google.com with SMTP id f6-v6so1466150plo.1 for ; Tue, 28 Aug 2018 17:14:58 -0700 (PDT) Date: Tue, 28 Aug 2018 17:14:54 -0700 From: Brian Norris Subject: Re: [PATCH] ath10k: retrieve MAC address from firmware if provided Message-ID: <20180829001453.GA173345@ban.mtv.corp.google.com> References: <20180810233948.144792-1-briannorris@chromium.org> <5B6F2A47.7070502@broadcom.com> <5B71CDFB.60408@broadcom.com> <878t4qftnm.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <878t4qftnm.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Arend van Spriel , govinds@codeaurora.org, linux-wireless@vger.kernel.org, Linux Kernel , ath10k@lists.infradead.org On Tue, Aug 28, 2018 at 05:33:01PM +0300, Kalle Valo wrote: > Arend van Spriel writes: > > > On 8/13/2018 7:14 PM, Brian Norris wrote: > >> On Sat, Aug 11, 2018 at 11:26 AM Arend van Spriel > >> wrote: > >>> > >>> On 8/11/2018 1:39 AM, Brian Norris wrote: > >>>> Devices may provide their own MAC address via system firmware (e.g., > >>> > >>> You got me confused by using just "firmware" in the subject. > >> > >> Yeah...I started by writing this patch with device tree specifically > >> (of_get_mac_address()), and then later found that there were generic > >> "device" helpers for this, which can assist with other sorts of > >> firmware nodes. It was easier to put a name on a device tree patch > >> than on a "device" patch. I suppose "system firmware" might be a > >> better description? > >> > >>>> device tree), especially in the case where the device doesn't have a > >>>> useful EEPROM on which to store its MAC address (e.g., for integrated > >>>> Wifi). > >>>> > >>>> Use the generic device helper to retrieve the MAC address, and (if > >>>> present) honor it above the MAC address advertised by the card. > >>> > >>> But this put me back on track ;-) > >> > >> Let me know if you have a better way to clarify. I can resend with a > >> slightly modified subject (s/firmware/system firmware/), or let Kalle > >> do it, if that's the only thing to change. > > > > "system firmware" substitution works for me. > > What about: > > ath10k: retrieve MAC address from Device Tree if provided > > Because from ath10k point of view we use Device Tree functions and don't > care if it's delivered by pidgeons or by system firmware :) I don't care too much, but note that Device Tree is a loaded term, usually referring specifically to a method of describing system hardware via the Flattened Device Tree format. If I were specifically targeting Device Tree, I'd use helpers like of_get_mac_address() instead. (The 'of_*' prefix is a relic of OpenFirmware, an early firmware implementation that used the Device Tree format.) If you're trying to say "device tree" to refer to "the Linux device hierarchy", then that's also a fair description. But that's all starting to mince words. Device Tree (with or without capitalization) is fine with me. Thanks, Brian > I can change this before I commit. > > -- > Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k