All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com
Subject: Re: [PATCH] mbuf: add IGMP packet type
Date: Wed, 29 Aug 2018 09:34:36 -0700	[thread overview]
Message-ID: <20180829093436.3f06421f@xeon-e3> (raw)
In-Reply-To: <20180829155904.GA7133@jerin>

On Wed, 29 Aug 2018 21:29:05 +0530
Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:

> -----Original Message-----
> > Date: Wed, 29 Aug 2018 08:31:10 -0700
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Cc: dev@dpdk.org, olivier.matz@6wind.com
> > Subject: Re: [dpdk-dev]  [PATCH] mbuf: add IGMP packet type
> > 
> > External Email
> > 
> > On Mon, 27 Aug 2018 18:08:35 +0530
> > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> >   
> > > Add support for IGMP packet type.
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>  
> > 
> > Could you add logic to recoginize IGMP to the software packet type identification
> > rte_net_get_ptype used by drivers that don't have hardware support.  
> 
> If everyone agrees then I can do it as adding IGMP support will reduce
> the performance of rte_net_get_ptype() and most of the NIC may not need it.
> 
> Opinions?
> 
> > 
> > Also shouldn't this bit be part of RTE_PTYPE_L4_MASK?  
> 
> The RTE_PTYPE_L4_MASK is 0x00000f00 so it is part it. Right?

Then you must add it to the software matcher since most drivers are advertising L4_MASK

  reply	other threads:[~2018-08-29 16:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27 12:38 [PATCH] mbuf: add IGMP packet type Jerin Jacob
2018-08-29  5:35 ` Honnappa Nagarahalli
2018-08-29  7:07 ` Andrew Rybchenko
2018-08-29 15:31 ` Stephen Hemminger
2018-08-29 15:59   ` Jerin Jacob
2018-08-29 16:34     ` Stephen Hemminger [this message]
2018-08-29 16:40       ` Jerin Jacob
2018-08-29 16:38     ` Stephen Hemminger
2018-10-23  9:20 ` Olivier Matz
2018-10-25 13:57   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829093436.3f06421f@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.