From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] mbuf: add IGMP packet type
Date: Wed, 29 Aug 2018 09:38:53 -0700
Message-ID: <20180829093853.5f866760@xeon-e3>
References: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com>
 <20180829083110.42d85024@xeon-e3> <20180829155904.GA7133@jerin>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, olivier.matz@6wind.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com
 [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id C5404F11
 for <dev@dpdk.org>; Wed, 29 Aug 2018 18:39:00 +0200 (CEST)
Received: by mail-pl1-f196.google.com with SMTP id ba4-v6so2528199plb.11
 for <dev@dpdk.org>; Wed, 29 Aug 2018 09:39:00 -0700 (PDT)
In-Reply-To: <20180829155904.GA7133@jerin>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 29 Aug 2018 21:29:05 +0530
Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:

> -----Original Message-----
> > Date: Wed, 29 Aug 2018 08:31:10 -0700
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Cc: dev@dpdk.org, olivier.matz@6wind.com
> > Subject: Re: [dpdk-dev]  [PATCH] mbuf: add IGMP packet type
> > 
> > External Email
> > 
> > On Mon, 27 Aug 2018 18:08:35 +0530
> > Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> >   
> > > Add support for IGMP packet type.
> > >
> > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>  
> > 
> > Could you add logic to recoginize IGMP to the software packet type identification
> > rte_net_get_ptype used by drivers that don't have hardware support.  
> 
> If everyone agrees then I can do it as adding IGMP support will reduce
> the performance of rte_net_get_ptype() and most of the NIC may not need it.

Since IGMP is an IP protocol field and the code is already looking for
TCP and UDP, how could adding another else slow it down in any observable way.