From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AFE8C433F5 for ; Wed, 29 Aug 2018 17:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3CD320652 for ; Wed, 29 Aug 2018 17:54:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3CD320652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727999AbeH2VwO (ORCPT ); Wed, 29 Aug 2018 17:52:14 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60182 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727392AbeH2VwN (ORCPT ); Wed, 29 Aug 2018 17:52:13 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7THiSAc036250 for ; Wed, 29 Aug 2018 13:54:12 -0400 Received: from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206]) by mx0b-001b2d01.pphosted.com with ESMTP id 2m5w7fra6q-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 29 Aug 2018 13:54:11 -0400 Received: from localhost by e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 29 Aug 2018 13:54:11 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 29 Aug 2018 13:54:06 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w7THs5eg47120432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 29 Aug 2018 17:54:05 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A769B2064; Wed, 29 Aug 2018 13:53:01 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7897FB205F; Wed, 29 Aug 2018 13:53:01 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 29 Aug 2018 13:53:01 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 8570216C2EC5; Wed, 29 Aug 2018 10:54:05 -0700 (PDT) Date: Wed, 29 Aug 2018 10:54:05 -0700 From: "Paul E. McKenney" To: Andrew Morton Cc: Waiman Long , Alexander Viro , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, "Luis R. Rodriguez" , Kees Cook , Linus Torvalds , Jan Kara , Ingo Molnar , Miklos Szeredi , Matthew Wilcox , Larry Woodman , James Bottomley , "Wangkai (Kevin C)" , Michal Hocko Subject: Re: [PATCH 2/2] fs/dcache: Make negative dentries easier to be reclaimed Reply-To: paulmck@linux.vnet.ibm.com References: <1535476780-5773-1-git-send-email-longman@redhat.com> <1535476780-5773-3-git-send-email-longman@redhat.com> <20180828160150.9a45ee293c92708edb511eab@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180828160150.9a45ee293c92708edb511eab@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18082917-0072-0000-0000-000003994AB4 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009635; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01080649; UDB=6.00557440; IPR=6.00860635; MB=3.00022999; MTD=3.00000008; XFM=3.00000015; UTC=2018-08-29 17:54:10 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18082917-0073-0000-0000-0000493E232D Message-Id: <20180829175405.GA17337@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-08-29_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=669 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1808290178 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 28, 2018 at 04:01:50PM -0700, Andrew Morton wrote: > > Another pet peeve ;) > > On Tue, 28 Aug 2018 13:19:40 -0400 Waiman Long wrote: > > > /** > > + * list_lru_add_head: add an element to the lru list's head > > + * @list_lru: the lru pointer > > + * @item: the item to be added. > > + * > > + * This is similar to list_lru_add(). The only difference is the location > > + * where the new item will be added. The list_lru_add() function will add > > People often use the term "the foo() function". I don't know why - > just say "foo()"! For whatever it is worth... I tend to use "The foo() function ..." instead of "foo() ..." in order to properly capitalize the first word of the sentence. So I might say "The call_rcu() function enqueues an RCU callback." rather than something like "call_rcu() enqueues an RCU callback." Or I might use some other trick to keep "call_rcu()" from being the first word of the sentence. But if the end of the previous sentence introduced call_rcu(), you usually want the next sentence's first use of "call_rcu()" to be very early in the sentence, because otherwise the flow will seem choppy. And no, I have no idea what I would do if I were writing in German, where nouns are capitalized, given that function names tend to be used as nouns. Probably I would get yelled at a lot for capitalizing my function names. ;-) Thanx, Paul