From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH bpf-next 08/11] i40e: add AF_XDP zero-copy Rx support
Date: Wed, 29 Aug 2018 12:22:31 -0700
Message-ID: <20180829192229.5xyvuy66itn5qzsf@ast-mbp.dhcp.thefacebook.com>
References: <20180828124435.30578-1-bjorn.topel@gmail.com>
 <20180828124435.30578-9-bjorn.topel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: magnus.karlsson@intel.com, magnus.karlsson@gmail.com,
        alexander.h.duyck@intel.com, alexander.duyck@gmail.com,
        ast@kernel.org, brouer@redhat.com, daniel@iogearbox.net,
        netdev@vger.kernel.org, jesse.brandeburg@intel.com,
        anjali.singhai@intel.com, peter.waskiewicz.jr@intel.com,
        =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@intel.com>,
        michael.lundkvist@ericsson.com, willemdebruijn.kernel@gmail.com,
        john.fastabend@gmail.com, jakub.kicinski@netronome.com,
        neerav.parikh@intel.com, mykyta.iziumtsev@linaro.org,
        francois.ozog@linaro.org, ilias.apalodimas@linaro.org,
        brian.brooks@linaro.org, u9012063@gmail.com, pavel@fastnetmon.com,
        qi.z.zhang@intel.com
To: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f194.google.com ([209.85.214.194]:33763 "EHLO
        mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726633AbeH2XUy (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 29 Aug 2018 19:20:54 -0400
Received: by mail-pl1-f194.google.com with SMTP id 60-v6so2735862ple.0
        for <netdev@vger.kernel.org>; Wed, 29 Aug 2018 12:22:35 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180828124435.30578-9-bjorn.topel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Aug 28, 2018 at 02:44:32PM +0200, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@intel.com>
> 
> This patch adds zero-copy Rx support for AF_XDP sockets. Instead of
> allocating buffers of type MEM_TYPE_PAGE_SHARED, the Rx frames are
> allocated as MEM_TYPE_ZERO_COPY when AF_XDP is enabled for a certain
> queue.
> 
> All AF_XDP specific functions are added to a new file, i40e_xsk.c.
> 
> Note that when AF_XDP zero-copy is enabled, the XDP action XDP_PASS
> will allocate a new buffer and copy the zero-copy frame prior passing
> it to the kernel stack.
> 
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
...
> +/**
> + * i40e_construct_skb_zc - Create skbufff from zero-copy Rx buffer

typo sk_buff

overall the set looks great to me. The driver side changes look
particularly clean and independent from skb path of the driver.
I think the issues brought up by other reviews are not blockers
for the set, but certainly should be addressed in the follow up patches.