From: Oscar Salvador <osalvador@techadventures.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mhocko@suse.com, vbabka@suse.cz, Pavel.Tatashin@microsoft.com,
sfr@canb.auug.org.au, iamjoonsoo.kim@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Oscar Salvador <osalvador@suse.de>,
Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: Re: [PATCH] mm/page_alloc: Clean up check_for_memory
Date: Wed, 29 Aug 2018 22:34:32 +0200 [thread overview]
Message-ID: <20180829203432.GA24978@techadventures.net> (raw)
In-Reply-To: <20180828143530.4b681bf9e0b3c03519fbe943@linux-foundation.org>
On Tue, Aug 28, 2018 at 02:35:30PM -0700, Andrew Morton wrote:
> > First, we should only set N_HIGH_MEMORY in case we have
> > CONFIG_HIGHMEM.
>
> Why? Just a teeny optimization?
Hi Andrew,
Optimization was not really my point here, my point was to make
the code less subtle and more clear.
One may wonder why we set N_HIGH_MEMORY unconditionally when
__only__ CONFIG_HIGHMEM matters for this case, and why we set
N_NORMAL_MEMORY __only__ for CONFIG_HIGHMEM when we should not care
about that at all.
I do not really expect a big impact here, mainly because check_for_memory
is only being used during boot.
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-08-29 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 21:01 [PATCH] mm/page_alloc: Clean up check_for_memory Oscar Salvador
2018-08-28 21:35 ` Andrew Morton
2018-08-29 20:34 ` Oscar Salvador [this message]
2018-08-30 1:55 ` Pasha Tatashin
2018-08-31 12:24 ` Oscar Salvador
2018-08-31 14:04 ` Pasha Tatashin
2018-08-31 20:45 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829203432.GA24978@techadventures.net \
--to=osalvador@techadventures.net \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.