From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: to wait or not to wait.. DPDK & OVS ixgbe with fibre
 disconnected
Date: Fri, 31 Aug 2018 08:12:05 -0700
Message-ID: <20180831081205.7a588890@xeon-e3>
References: <CAB8HAh6nJmVn2SbssnyxwhvYqRvcjqYKaVaDxYHt2YDJ46TzYg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: qiming.yang@intel.com, dev@dpdk.org
To: David Evans <davidjoshuaevans@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com
 [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 07E7C1AEF0
 for <dev@dpdk.org>; Fri, 31 Aug 2018 17:12:14 +0200 (CEST)
Received: by mail-pl1-f194.google.com with SMTP id b12-v6so5608044plr.8
 for <dev@dpdk.org>; Fri, 31 Aug 2018 08:12:13 -0700 (PDT)
In-Reply-To: <CAB8HAh6nJmVn2SbssnyxwhvYqRvcjqYKaVaDxYHt2YDJ46TzYg@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 29 Aug 2018 16:57:55 -0500
David Evans <davidjoshuaevans@gmail.com> wrote:

> Hi!
> 
> We have a thread running on ovs discuss. - Can you contribute?
> 
> regarding ixgbe_ethdev.c
> 
>   ixgbe_dev_link_update() doesn't honour wait_to_complete flag always.
> 
> Basically, where you have 'wait_to_complete' set to 0, we are still having
> to wait sometimes
> Dpdk is always attempting setup if intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG
> Which happens if you unplug fibre, or don't plug it in.
> 
> is there a better way to handle this? It is causing OVS to get stuck
> busy... on the thread that calls this.
> 
> eg:
>  in line 4000  -  ixgbe_setup_link(hw,speed,true)
> 
>         if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
>                 ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>                 speed = hw->phy.autoneg_advertised;
>                 if (!speed)
>                         ixgbe_get_link_capabilities(hw, &speed, &autoneg);
>                 ixgbe_setup_link(hw, speed, true);
>         }
> 
> 
> or also...
> 
> #0  rte_delay_us_block (us=100000) at
> /usr/src/debug/dpdk-17.11.3/lib/librte_eal/common/eal_common_timer.c:59
> #1  0x00007f548f79ceec in ixgbe_setup_mac_link_multispeed_fiber
> (hw=0x7f543fc2f680, speed=128, autoneg_wait_to_complete=0) at
> /usr/src/debug/dpdk-17.11.3/drivers/net/ixgbe/base/ixgbe_common.c:5155
> #2  0x00007f548f7c2cb2 in ixgbe_dev_link_update_share (vf=0,
> wait_to_complete=0, dev=0x7f549492d480 <rte_eth_devices+82560>) at
> /usr/src/debug/dpdk-17.11.3/drivers/net/ixgbe/ixgbe_ethdev.c:4000
> #3  ixgbe_dev_link_update (dev=0x7f549492d480 <rte_eth_devices+82560>,
> wait_to_complete=0) at
> /usr/src/debug/dpdk-17.11.3/drivers/net/ixgbe/ixgbe_ethdev.c:4070
> 
> Thanks so much
> 
> Dave.

In my experience the wait flag is pretty useless. It means "wait until link is up"
which means the wait loop happens in the driver when it is better handled by the
application. Also, many drivers do not implement it.