From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup Date: Fri, 31 Aug 2018 11:04:39 +0200 Message-ID: <20180831090439.GT21634@phenom.ffwll.local> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Alex Deucher , Thierry Reding , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, Maxime Ripard , linux-arm-kernel@lists.infradead.org List-Id: linux-tegra@vger.kernel.org T24gVGh1LCBBdWcgMzAsIDIwMTggYXQgMTE6MDA6MDFQTSArMDIwMCwgTWljaGHFgiBNaXJvc8WC YXcgd3JvdGU6Cj4gVGhpcyBzZXJpZXMgY2xlYW5zIHVwIGR1cGxpY2F0ZWQgY29kZSBmb3IgcmVw bGFjaW5nIGZpcm13YXJlIEZCCj4gZHJpdmVyIHdpdGggcHJvcGVyIERSSSBkcml2ZXIgYW5kIGFk ZHMgaGFuZG92ZXIgc3VwcG9ydCB0bwo+IFRlZ3JhIGRyaXZlci4KPiAKPiBUaGlzIGlzIGEgc2xp Z3RseSB1cGRhdGVkIHZlcnNpb24gb2YgYSBzZXJpZXMgc2VudCBvbiAyNCBOb3YgMjAxNy4KPiAK PiB2MjoKPiAgLSByZWJhc2VkIG9uIGN1cnJlbnQgZHJtLW5leHQKPiAgLSBkcm9wcGVkIHN0YWdp bmcvc203NTBmYiBjaGFuZ2VzCj4gIC0gYWRkZWQga2VybmVsIGRvY3MgZm9yIERSTSBoZWxwZXJz Cj4gCj4gTWljaGHFgiBNaXJvc8WCYXcgKDEyKToKPiAgIGZiZGV2OiBzaG93IGZiZGV2IG51bWJl ciBmb3IgZGVidWdnaW5nCj4gICBmYmRldjogYWxsb3cgYXBlcnR1cmVzID09IE5VTEwgaW4gcmVt b3ZlX2NvbmZsaWN0aW5nX2ZyYW1lYnVmZmVycygpCj4gICBmYmRldjogYWRkIHJlbW92ZV9jb25m bGljdGluZ19wY2lfZnJhbWVidWZmZXJzKCkKPiAgIGRybS9hbWRncHU6IHVzZSBzaW1wbGVyIHJl bW92ZV9jb25mbGljdGluZ19wY2lfZnJhbWVidWZmZXJzKCkKPiAgIGRybS9ib2NoczogdXNlIHNp bXBsZXIgcmVtb3ZlX2NvbmZsaWN0aW5nX3BjaV9mcmFtZWJ1ZmZlcnMoKQo+ICAgZHJtL2NpcnJ1 czogdXNlIHNpbXBsZXIgcmVtb3ZlX2NvbmZsaWN0aW5nX3BjaV9mcmFtZWJ1ZmZlcnMoKQo+ICAg ZHJtL21nYWcyMDA6IHVzZSBzaW1wbGVyIHJlbW92ZV9jb25mbGljdGluZ19wY2lfZnJhbWVidWZm ZXJzKCkKPiAgIGRybS9yYWRlb246IHVzZSBzaW1wbGVyIHJlbW92ZV9jb25mbGljdGluZ19wY2lf ZnJhbWVidWZmZXJzKCkKPiAgIGRybS92aXJ0aW86IHVzZSBzaW1wbGVyIHJlbW92ZV9jb25mbGlj dGluZ19wY2lfZnJhbWVidWZmZXJzKCkKPiAgIGRybS92YzQ6IHVzZSBzaW1wbGVyIHJlbW92ZV9j b25mbGljdGluZ19mcmFtZWJ1ZmZlcnMoTlVMTCkKPiAgIGRybS9zdW40aTogdXNlIHNpbXBsZXIg cmVtb3ZlX2NvbmZsaWN0aW5nX2ZyYW1lYnVmZmVycyhOVUxMKQo+ICAgZHJtL3RlZ3JhOiBraWNr IG91dCBzaW1wbGVmYgoKTG9va3MgdmVyeSBuZWF0LiBBIGJpdCBjb25mdXNlZCBhYm91dCB0aGUg ZHJtIGNoYW5nZXMgaW4gdGhlIGZiZGV2LXRpdGxlZApwYXRjaGVzIDEmMywgYnV0IEkgZ3Vlc3Mg d2UgY2FuIG1lcmdlIGFzLWlzLiBVcCB0byB5b3Ugd2hldGhlciB5b3Ugd2FudCB0bwpzcGxpdCBv ciBub3QgSSdkIHNheS4KCkJhcnRsb21pZWosIGFjayBmb3IgcHVsbGluIGluIHRoaXMgZW50aXJl IHBpbGUgdGhyb3VnaCBkcm0tbWlzYz8KClRoYW5rcywgRGFuaWVsCgo+IAo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZHJ2LmMgIHwgMjQgKy0tLS0tLS0tLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX2Rydi5jICAgICAgICB8IDE4ICstLS0tLS0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9jaXJydXMvY2lycnVzX2Rydi5jICAgICAgfCAyMyArLS0tLS0tLS0t LS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX2Rydi5jICAgIHwgMjEgKy0t LS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbWdhZzIwMC9tZ2FnMjAwX21haW4uYyAgIHwg IDkgLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rydi5jICAgICAgfCAy MyArLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfZHJ2LmMgICAg ICAgIHwgMTggKy0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2RybS5jICAgICAg ICAgICAgICB8ICA0ICsrKwo+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYuYyAgICAgICAg ICAgIHwgMjAgKy0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9k cm1fYnVzLmMgfCAyNCArKy0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL3ZpZGVvL2ZiZGV2L2NvcmUv ZmJtZW0uYyAgICAgICAgIHwgNDAgKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIGluY2x1ZGUv ZHJtL2RybV9mYl9oZWxwZXIuaCAgICAgICAgICAgICAgfCAzNCArKysrKysrKysrKysrKysrKysr Kwo+ICBpbmNsdWRlL2xpbnV4L2ZiLmggICAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysKPiAg MTMgZmlsZXMgY2hhbmdlZCwgODggaW5zZXJ0aW9ucygrKSwgMTcyIGRlbGV0aW9ucygtKQo+IAo+ IC0tIAo+IDIuMTguMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVs IENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0 dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4 Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Fri, 31 Aug 2018 09:04:39 +0000 Subject: Re: [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup Message-Id: <20180831090439.GT21634@phenom.ffwll.local> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , amd-gfx@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Alex Deucher , Thierry Reding , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, Maxime Ripard , linux-arm-kernel@lists.infradead.org On Thu, Aug 30, 2018 at 11:00:01PM +0200, Michał Mirosław wrote: > This series cleans up duplicated code for replacing firmware FB > driver with proper DRI driver and adds handover support to > Tegra driver. > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > v2: > - rebased on current drm-next > - dropped staging/sm750fb changes > - added kernel docs for DRM helpers > > Michał Mirosław (12): > fbdev: show fbdev number for debugging > fbdev: allow apertures = NULL in remove_conflicting_framebuffers() > fbdev: add remove_conflicting_pci_framebuffers() > drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() > drm/bochs: use simpler remove_conflicting_pci_framebuffers() > drm/cirrus: use simpler remove_conflicting_pci_framebuffers() > drm/mgag200: use simpler remove_conflicting_pci_framebuffers() > drm/radeon: use simpler remove_conflicting_pci_framebuffers() > drm/virtio: use simpler remove_conflicting_pci_framebuffers() > drm/vc4: use simpler remove_conflicting_framebuffers(NULL) > drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) > drm/tegra: kick out simplefb Looks very neat. A bit confused about the drm changes in the fbdev-titled patches 1&3, but I guess we can merge as-is. Up to you whether you want to split or not I'd say. Bartlomiej, ack for pullin in this entire pile through drm-misc? Thanks, Daniel > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +------------- > drivers/gpu/drm/bochs/bochs_drv.c | 18 +---------- > drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +------------- > drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +------------ > drivers/gpu/drm/mgag200/mgag200_main.c | 9 ------ > drivers/gpu/drm/radeon/radeon_drv.c | 23 +------------- > drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +---------- > drivers/gpu/drm/tegra/drm.c | 4 +++ > drivers/gpu/drm/vc4/vc4_drv.c | 20 +----------- > drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 ++------------ > drivers/video/fbdev/core/fbmem.c | 40 ++++++++++++++++++++++-- > include/drm/drm_fb_helper.h | 34 ++++++++++++++++++++ > include/linux/fb.h | 2 ++ > 13 files changed, 88 insertions(+), 172 deletions(-) > > -- > 2.18.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel@ffwll.ch (Daniel Vetter) Date: Fri, 31 Aug 2018 11:04:39 +0200 Subject: [PATCH v2 00/12] remove_conflicting_framebuffers() cleanup In-Reply-To: References: Message-ID: <20180831090439.GT21634@phenom.ffwll.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 30, 2018 at 11:00:01PM +0200, Micha? Miros?aw wrote: > This series cleans up duplicated code for replacing firmware FB > driver with proper DRI driver and adds handover support to > Tegra driver. > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > v2: > - rebased on current drm-next > - dropped staging/sm750fb changes > - added kernel docs for DRM helpers > > Micha? Miros?aw (12): > fbdev: show fbdev number for debugging > fbdev: allow apertures == NULL in remove_conflicting_framebuffers() > fbdev: add remove_conflicting_pci_framebuffers() > drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() > drm/bochs: use simpler remove_conflicting_pci_framebuffers() > drm/cirrus: use simpler remove_conflicting_pci_framebuffers() > drm/mgag200: use simpler remove_conflicting_pci_framebuffers() > drm/radeon: use simpler remove_conflicting_pci_framebuffers() > drm/virtio: use simpler remove_conflicting_pci_framebuffers() > drm/vc4: use simpler remove_conflicting_framebuffers(NULL) > drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) > drm/tegra: kick out simplefb Looks very neat. A bit confused about the drm changes in the fbdev-titled patches 1&3, but I guess we can merge as-is. Up to you whether you want to split or not I'd say. Bartlomiej, ack for pullin in this entire pile through drm-misc? Thanks, Daniel > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +------------- > drivers/gpu/drm/bochs/bochs_drv.c | 18 +---------- > drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +------------- > drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +------------ > drivers/gpu/drm/mgag200/mgag200_main.c | 9 ------ > drivers/gpu/drm/radeon/radeon_drv.c | 23 +------------- > drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +---------- > drivers/gpu/drm/tegra/drm.c | 4 +++ > drivers/gpu/drm/vc4/vc4_drv.c | 20 +----------- > drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 ++------------ > drivers/video/fbdev/core/fbmem.c | 40 ++++++++++++++++++++++-- > include/drm/drm_fb_helper.h | 34 ++++++++++++++++++++ > include/linux/fb.h | 2 ++ > 13 files changed, 88 insertions(+), 172 deletions(-) > > -- > 2.18.0 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch