From: David Miller <davem@davemloft.net>
To: tony@atomide.com
Cc: netdev@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, andrew@lunn.ch,
grygorii.strashko@ti.com, ivan.khoronzhuk@linaro.org,
mark.rutland@arm.com, m-karicheri2@ti.com, robh+dt@kernel.org
Subject: Re: [PATCH 2/2] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel
Date: Sun, 02 Sep 2018 13:52:51 -0700 (PDT) [thread overview]
Message-ID: <20180902.135251.1636829495138774363.davem@davemloft.net> (raw)
In-Reply-To: <20180829150024.43210-2-tony@atomide.com>
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 29 Aug 2018 08:00:24 -0700
> The cpsw-phy-sel device is not a child of the cpsw interconnect target
> module. It lives in the system control module.
>
> Let's fix this issue by trying to use cpsw-phy-sel phandle first if it
> exists and if not fall back to current usage of trying to find the
> cpsw-phy-sel child. That way the phy sel driver can be a child of the
> system control module where it belongs in the device tree.
>
> Without this fix, we cannot have a proper interconnect target module
> hierarchy in device tree for things like genpd.
>
> Note that deferred probe is mostly not supported by cpsw and this patch
> does not attempt to fix that. In case deferred probe support is needed,
> this could be added to cpsw_slave_open() and phy_connect() so they start
> handling and returning errors.
>
> For documenting it, looks like the cpsw-phy-sel is used for all cpsw device
> tree nodes. It's missing the related binding documentation, so let's also
> update the binding documentation accordingly.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Applied.
next prev parent reply other threads:[~2018-09-03 1:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 15:00 [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle Tony Lindgren
2018-08-29 15:00 ` [PATCH 2/2] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel Tony Lindgren
2018-09-02 20:52 ` David Miller [this message]
2018-08-30 0:08 ` [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle Grygorii Strashko
2018-08-30 0:08 ` Grygorii Strashko
2018-08-30 0:47 ` Tony Lindgren
2018-08-30 1:18 ` Andrew Lunn
2018-08-30 17:04 ` Grygorii Strashko
2018-08-30 17:04 ` Grygorii Strashko
2018-08-30 21:55 ` Tony Lindgren
2018-09-02 20:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902.135251.1636829495138774363.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.