From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Baoquan He <bhe@redhat.com>
Cc: tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com,
thgarnie@google.com, kirill.shutemov@linux.intel.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86/mm/KASLR: Adjust the vmemmap size according to paging mode
Date: Sun, 2 Sep 2018 23:52:42 +0300 [thread overview]
Message-ID: <20180902205242.kcpt6wsatacahswp@kshutemo-mobl1> (raw)
In-Reply-To: <20180830152512.GE14702@192.168.1.2>
On Thu, Aug 30, 2018 at 11:25:12PM +0800, Baoquan He wrote:
> Hi Kirill,
>
> I made a new version according to your suggestion, just a little
> different, I didn't make 1TB as default, just calculate with the actual
> size, then align up to 1TB boundary. Just found kcore is printing more
> entries than before, I thought it's caused by my code, later got it was
> touchde by other people.
>
> Any comment about this? I can change accordingly.
Looks good to me.
But there's corner case when struct page is unreasonably large and
vmemmap_size will be way to large. We probably have to report an error if
we cannot fit vmemmap properly into virtual memory layout.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2018-09-02 20:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 2:17 [PATCH 1/2] x86/mm/KASLR: Fix the wrong calculation of kalsr region initial size Baoquan He
2018-08-29 2:17 ` [PATCH 2/2] x86/mm/KASLR: Adjust the vmemmap size according to paging mode Baoquan He
2018-08-29 12:05 ` Kirill A. Shutemov
2018-08-29 12:16 ` Baoquan He
2018-08-29 12:18 ` Baoquan He
2018-08-29 12:26 ` Kirill A. Shutemov
2018-08-29 12:51 ` Baoquan He
2018-08-30 15:25 ` Baoquan He
2018-09-02 20:52 ` Kirill A. Shutemov [this message]
2018-09-03 7:47 ` Baoquan He
2018-09-03 10:26 ` Kirill A. Shutemov
2018-09-03 14:52 ` Baoquan He
2018-09-04 8:13 ` Kirill A. Shutemov
2018-09-05 8:15 ` Baoquan He
2018-09-05 12:09 ` Kirill A. Shutemov
2018-09-05 12:37 ` Baoquan He
2018-08-29 11:49 ` [PATCH 1/2] x86/mm/KASLR: Fix the wrong calculation of kalsr region initial size Kirill A. Shutemov
2018-09-04 17:57 ` Thomas Garnier
2018-09-08 12:10 ` Thomas Gleixner
2018-09-08 13:33 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180902205242.kcpt6wsatacahswp@kshutemo-mobl1 \
--to=kirill@shutemov.name \
--cc=bhe@redhat.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.