From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH kvm-unit-tests 2/2] arm64: add micro-bench
Date: Mon, 3 Sep 2018 14:11:30 +0200
Message-ID: <20180903121130.uhkkz2avwknhxobs@kamzik.brq.redhat.com>
References: <20180830141733.21725-1-drjones@redhat.com>
 <20180830141733.21725-3-drjones@redhat.com>
 <20180903111236.GH4029@e113682-lin.lund.arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Christoffer Dall <cdall@cs.columbia.edu>, kvm@vger.kernel.org,
 marc.zyngier@arm.com, ynorov@caviumnetworks.com, kvmarm@lists.cs.columbia.edu,
 shihwei@cs.columbia.edu
To: Christoffer Dall <christoffer.dall@arm.com>
Return-path: <kvmarm-bounces@lists.cs.columbia.edu>
Content-Disposition: inline
In-Reply-To: <20180903111236.GH4029@e113682-lin.lund.arm.com>
List-Unsubscribe: <https://lists.cs.columbia.edu/mailman/options/kvmarm>,
 <mailto:kvmarm-request@lists.cs.columbia.edu?subject=unsubscribe>
List-Archive: <https://lists.cs.columbia.edu/pipermail/kvmarm>
List-Post: <mailto:kvmarm@lists.cs.columbia.edu>
List-Help: <mailto:kvmarm-request@lists.cs.columbia.edu?subject=help>
List-Subscribe: <https://lists.cs.columbia.edu/mailman/listinfo/kvmarm>,
 <mailto:kvmarm-request@lists.cs.columbia.edu?subject=subscribe>
Errors-To: kvmarm-bounces@lists.cs.columbia.edu
Sender: kvmarm-bounces@lists.cs.columbia.edu
List-Id: kvm.vger.kernel.org

On Mon, Sep 03, 2018 at 01:12:36PM +0200, Christoffer Dall wrote:
> On Thu, Aug 30, 2018 at 04:17:33PM +0200, Andrew Jones wrote:
> > From: Shih-Wei Li <shihwei@cs.columbia.edu>
> > 
> > Here we provide the support for measuring various micro level
> > operations on arm64. Measurements are currently obtained using
> > timer counters. Further modifications in KVM will be required
> > to support timestamping using cycle counters, as KVM now disables
> > accesses to the PMU counters from the VM.
> > 
> > Signed-off-by: Shih-Wei Li <shihwei@cs.columbia.edu>
> > Signed-off-by: Christoffer Dall <cdall@cs.columbia.edu>
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> 
> Acked-by: Christoffer Dall <christoffer.dall@arm.com>

Thanks Christoffer! While running this I just noticed a bug though.
It seemed my hardware was super-duper fast, because I was missing...

> > +#define PS_PER_SEC (1000 * 1000 * 1000 * 1000U)
                                    ...an 'L' here ^

I'll send a v2 with that fix now and also add your acked-by.

Thanks,
drew