From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C20BC43334 for ; Mon, 3 Sep 2018 19:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CA2F20867 for ; Mon, 3 Sep 2018 19:19:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CA2F20867 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728371AbeICXlI (ORCPT ); Mon, 3 Sep 2018 19:41:08 -0400 Received: from mga17.intel.com ([192.55.52.151]:15605 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727955AbeICXlI (ORCPT ); Mon, 3 Sep 2018 19:41:08 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2018 12:19:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,326,1531810800"; d="scan'208";a="80568278" Received: from fonsecan-mobl.ger.corp.intel.com (HELO localhost) ([10.249.36.49]) by orsmga003.jf.intel.com with ESMTP; 03 Sep 2018 12:19:27 -0700 Date: Mon, 3 Sep 2018 22:19:26 +0300 From: Jarkko Sakkinen To: Sean Christopherson Cc: "Huang, Kai" , "platform-driver-x86@vger.kernel.org" , "x86@kernel.org" , "nhorman@redhat.com" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "suresh.b.siddha@intel.com" , "Ayoun, Serge" , "hpa@zytor.com" , "npmccallum@redhat.com" , "mingo@redhat.com" , "linux-sgx@vger.kernel.org" , "Hansen, Dave" Subject: Re: [PATCH v13 10/13] x86/sgx: Add sgx_einit() for initializing enclaves Message-ID: <20180903191926.GC13497@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-11-jarkko.sakkinen@linux.intel.com> <1535406078.3416.9.camel@intel.com> <20180828070129.GA5301@linux.intel.com> <105F7BF4D0229846AF094488D65A09893541037C@PGSMSX112.gar.corp.intel.com> <20180831121645.GA18075@linux.intel.com> <20180831181509.GB21555@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180831181509.GB21555@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 31, 2018 at 11:15:09AM -0700, Sean Christopherson wrote: > On Fri, Aug 31, 2018 at 03:17:03PM +0300, Jarkko Sakkinen wrote: > > On Wed, Aug 29, 2018 at 07:33:54AM +0000, Huang, Kai wrote: > > > [snip..] > > > > > > > > > > > > > > > @@ -38,6 +39,18 @@ static LIST_HEAD(sgx_active_page_list); static > > > > > > DEFINE_SPINLOCK(sgx_active_page_list_lock); > > > > > > static struct task_struct *ksgxswapd_tsk; static > > > > > > DECLARE_WAIT_QUEUE_HEAD(ksgxswapd_waitq); > > > > > > +static struct notifier_block sgx_pm_notifier; static u64 > > > > > > +sgx_pm_cnt; > > > > > > + > > > > > > +/* The cache for the last known values of IA32_SGXLEPUBKEYHASHx > > > > > > +MSRs > > > > > > for each > > > > > > + * CPU. The entries are initialized when they are first used by > > > > > > sgx_einit(). > > > > > > + */ > > > > > > +struct sgx_lepubkeyhash { > > > > > > + u64 msrs[4]; > > > > > > + u64 pm_cnt; > > > > > > > > > > May I ask why do we need pm_cnt here? In fact why do we need suspend > > > > > staff (namely, sgx_pm_cnt above, and related code in this patch) here > > > > > in this patch? From the patch commit message I don't see why we need > > > > > PM staff here. Please give comment why you need PM staff, or you may > > > > > consider to split the PM staff to another patch. > > > > > > > > Refining the commit message probably makes more sense because without PM > > > > code sgx_einit() would be broken. The MSRs have been reset after waking up. > > > > > > > > Some kind of counter is required to keep track of the power cycle. When going > > > > to sleep the sgx_pm_cnt is increased. sgx_einit() compares the current value of > > > > the global count to the value in the cache entry to see whether we are in a new > > > > power cycle. > > > > > > You mean reset to Intel default? I think we can also just reset the > > > cached MSR values on each power cycle, which would be simpler, IMHO? > > > > I don't really see that much difference in the complexity. > > Tracking the validity of the cache means we're hosed if we miss any > condition that causes the MSRs to be reset. I think we're better off > assuming the cache can be stale at any time, i.e. don't track power > cyles and instead handle EINIT failure due to INVALID_TOKEN by writing > the cache+MSRs with the desired hash and retrying EINIT. EINIT is > interruptible and its latency is extremely variable in any case, e.g. > tens of thousands of cycles, so this rarely-hit "slow path" probably > wouldn't affect the worst case latency of EINIT. Sounds a good refiniment. Pretty good solution to heal from host sleep on the guest VM and then there is no need for driver changes. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com ([192.55.52.151]:15605 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727955AbeICXlI (ORCPT ); Mon, 3 Sep 2018 19:41:08 -0400 Date: Mon, 3 Sep 2018 22:19:26 +0300 From: Jarkko Sakkinen To: Sean Christopherson CC: "Huang, Kai" , "platform-driver-x86@vger.kernel.org" , "x86@kernel.org" , "nhorman@redhat.com" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "suresh.b.siddha@intel.com" , "Ayoun, Serge" , "hpa@zytor.com" , "npmccallum@redhat.com" , "mingo@redhat.com" , "linux-sgx@vger.kernel.org" , "Hansen, Dave" Subject: Re: [PATCH v13 10/13] x86/sgx: Add sgx_einit() for initializing enclaves Message-ID: <20180903191926.GC13497@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-11-jarkko.sakkinen@linux.intel.com> <1535406078.3416.9.camel@intel.com> <20180828070129.GA5301@linux.intel.com> <105F7BF4D0229846AF094488D65A09893541037C@PGSMSX112.gar.corp.intel.com> <20180831121645.GA18075@linux.intel.com> <20180831181509.GB21555@linux.intel.com> Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20180831181509.GB21555@linux.intel.com> Sender: List-ID: Return-Path: linux-sgx-owner@vger.kernel.org MIME-Version: 1.0 On Fri, Aug 31, 2018 at 11:15:09AM -0700, Sean Christopherson wrote: > On Fri, Aug 31, 2018 at 03:17:03PM +0300, Jarkko Sakkinen wrote: > > On Wed, Aug 29, 2018 at 07:33:54AM +0000, Huang, Kai wrote: > > > [snip..] > > > > > > > > > > > > > > > @@ -38,6 +39,18 @@ static LIST_HEAD(sgx_active_page_list); static > > > > > > DEFINE_SPINLOCK(sgx_active_page_list_lock); > > > > > > static struct task_struct *ksgxswapd_tsk; static > > > > > > DECLARE_WAIT_QUEUE_HEAD(ksgxswapd_waitq); > > > > > > +static struct notifier_block sgx_pm_notifier; static u64 > > > > > > +sgx_pm_cnt; > > > > > > + > > > > > > +/* The cache for the last known values of IA32_SGXLEPUBKEYHASHx > > > > > > +MSRs > > > > > > for each > > > > > > + * CPU. The entries are initialized when they are first used by > > > > > > sgx_einit(). > > > > > > + */ > > > > > > +struct sgx_lepubkeyhash { > > > > > > + u64 msrs[4]; > > > > > > + u64 pm_cnt; > > > > > > > > > > May I ask why do we need pm_cnt here? In fact why do we need suspend > > > > > staff (namely, sgx_pm_cnt above, and related code in this patch) here > > > > > in this patch? From the patch commit message I don't see why we need > > > > > PM staff here. Please give comment why you need PM staff, or you may > > > > > consider to split the PM staff to another patch. > > > > > > > > Refining the commit message probably makes more sense because without PM > > > > code sgx_einit() would be broken. The MSRs have been reset after waking up. > > > > > > > > Some kind of counter is required to keep track of the power cycle. When going > > > > to sleep the sgx_pm_cnt is increased. sgx_einit() compares the current value of > > > > the global count to the value in the cache entry to see whether we are in a new > > > > power cycle. > > > > > > You mean reset to Intel default? I think we can also just reset the > > > cached MSR values on each power cycle, which would be simpler, IMHO? > > > > I don't really see that much difference in the complexity. > > Tracking the validity of the cache means we're hosed if we miss any > condition that causes the MSRs to be reset. I think we're better off > assuming the cache can be stale at any time, i.e. don't track power > cyles and instead handle EINIT failure due to INVALID_TOKEN by writing > the cache+MSRs with the desired hash and retrying EINIT. EINIT is > interruptible and its latency is extremely variable in any case, e.g. > tens of thousands of cycles, so this rarely-hit "slow path" probably > wouldn't affect the worst case latency of EINIT. Sounds a good refiniment. Pretty good solution to heal from host sleep on the guest VM and then there is no need for driver changes. /Jarkko