From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Pankaj Gupta <pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: jack-AlSwsSmVLrQ@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org,
ross.zwisler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
lcapitulino-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
eblake-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
niteshnarayanlal-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org,
mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
nilal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org,
stefanha-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kbuild-all-JC7UmRfGjtg@public.gmane.org,
imammedo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH 3/3] virtio-pmem: Add virtio pmem driver
Date: Tue, 4 Sep 2018 23:17:00 +0800 [thread overview]
Message-ID: <20180904151700.GH17047@intel.com> (raw)
In-Reply-To: <20180831133019.27579-4-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi Pankaj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v4.19-rc2 next-20180903]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pankaj-Gupta/kvm-fake-DAX-device/20180903-160032
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: i386-randconfig-a3-201835 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
All errors (new ones prefixed by >>):
drivers/virtio/virtio_pmem.o: In function `virtio_pmem_remove':
>> drivers/virtio/virtio_pmem.c:220: undefined reference to `nvdimm_bus_unregister'
drivers/virtio/virtio_pmem.o: In function `virtio_pmem_probe':
>> drivers/virtio/virtio_pmem.c:186: undefined reference to `nvdimm_bus_register'
>> drivers/virtio/virtio_pmem.c:198: undefined reference to `nvdimm_pmem_region_create'
drivers/virtio/virtio_pmem.c:207: undefined reference to `nvdimm_bus_unregister'
# https://github.com/0day-ci/linux/commit/acce2633da18b0ad58d0cc9243a85b03020ca099
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout acce2633da18b0ad58d0cc9243a85b03020ca099
vim +220 drivers/virtio/virtio_pmem.c
acce2633 Pankaj Gupta 2018-08-31 147
acce2633 Pankaj Gupta 2018-08-31 148 static int virtio_pmem_probe(struct virtio_device *vdev)
acce2633 Pankaj Gupta 2018-08-31 149 {
acce2633 Pankaj Gupta 2018-08-31 150 int err = 0;
acce2633 Pankaj Gupta 2018-08-31 151 struct resource res;
acce2633 Pankaj Gupta 2018-08-31 152 struct virtio_pmem *vpmem;
acce2633 Pankaj Gupta 2018-08-31 153 struct nvdimm_bus *nvdimm_bus;
acce2633 Pankaj Gupta 2018-08-31 154 struct nd_region_desc ndr_desc;
acce2633 Pankaj Gupta 2018-08-31 155 int nid = dev_to_node(&vdev->dev);
acce2633 Pankaj Gupta 2018-08-31 156 struct nd_region *nd_region;
acce2633 Pankaj Gupta 2018-08-31 157
acce2633 Pankaj Gupta 2018-08-31 158 if (!vdev->config->get) {
acce2633 Pankaj Gupta 2018-08-31 159 dev_err(&vdev->dev, "%s failure: config disabled\n",
acce2633 Pankaj Gupta 2018-08-31 160 __func__);
acce2633 Pankaj Gupta 2018-08-31 161 return -EINVAL;
acce2633 Pankaj Gupta 2018-08-31 162 }
acce2633 Pankaj Gupta 2018-08-31 163
acce2633 Pankaj Gupta 2018-08-31 164 vdev->priv = vpmem = devm_kzalloc(&vdev->dev, sizeof(*vpmem),
acce2633 Pankaj Gupta 2018-08-31 165 GFP_KERNEL);
acce2633 Pankaj Gupta 2018-08-31 166 if (!vpmem) {
acce2633 Pankaj Gupta 2018-08-31 167 err = -ENOMEM;
acce2633 Pankaj Gupta 2018-08-31 168 goto out_err;
acce2633 Pankaj Gupta 2018-08-31 169 }
acce2633 Pankaj Gupta 2018-08-31 170
acce2633 Pankaj Gupta 2018-08-31 171 vpmem->vdev = vdev;
acce2633 Pankaj Gupta 2018-08-31 172 err = init_vq(vpmem);
acce2633 Pankaj Gupta 2018-08-31 173 if (err)
acce2633 Pankaj Gupta 2018-08-31 174 goto out_err;
acce2633 Pankaj Gupta 2018-08-31 175
acce2633 Pankaj Gupta 2018-08-31 176 virtio_cread(vpmem->vdev, struct virtio_pmem_config,
acce2633 Pankaj Gupta 2018-08-31 177 start, &vpmem->start);
acce2633 Pankaj Gupta 2018-08-31 178 virtio_cread(vpmem->vdev, struct virtio_pmem_config,
acce2633 Pankaj Gupta 2018-08-31 179 size, &vpmem->size);
acce2633 Pankaj Gupta 2018-08-31 180
acce2633 Pankaj Gupta 2018-08-31 181 res.start = vpmem->start;
acce2633 Pankaj Gupta 2018-08-31 182 res.end = vpmem->start + vpmem->size-1;
acce2633 Pankaj Gupta 2018-08-31 183 vpmem->nd_desc.provider_name = "virtio-pmem";
acce2633 Pankaj Gupta 2018-08-31 184 vpmem->nd_desc.module = THIS_MODULE;
acce2633 Pankaj Gupta 2018-08-31 185
acce2633 Pankaj Gupta 2018-08-31 @186 vpmem->nvdimm_bus = nvdimm_bus = nvdimm_bus_register(&vdev->dev,
acce2633 Pankaj Gupta 2018-08-31 187 &vpmem->nd_desc);
acce2633 Pankaj Gupta 2018-08-31 188 if (!nvdimm_bus)
acce2633 Pankaj Gupta 2018-08-31 189 goto out_vq;
acce2633 Pankaj Gupta 2018-08-31 190
acce2633 Pankaj Gupta 2018-08-31 191 dev_set_drvdata(&vdev->dev, nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 192 memset(&ndr_desc, 0, sizeof(ndr_desc));
acce2633 Pankaj Gupta 2018-08-31 193
acce2633 Pankaj Gupta 2018-08-31 194 ndr_desc.res = &res;
acce2633 Pankaj Gupta 2018-08-31 195 ndr_desc.numa_node = nid;
acce2633 Pankaj Gupta 2018-08-31 196 ndr_desc.flush = virtio_pmem_flush;
acce2633 Pankaj Gupta 2018-08-31 197 set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags);
acce2633 Pankaj Gupta 2018-08-31 @198 nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc);
acce2633 Pankaj Gupta 2018-08-31 199
acce2633 Pankaj Gupta 2018-08-31 200 if (!nd_region)
acce2633 Pankaj Gupta 2018-08-31 201 goto out_nd;
acce2633 Pankaj Gupta 2018-08-31 202
acce2633 Pankaj Gupta 2018-08-31 203 //virtio_device_ready(vdev);
acce2633 Pankaj Gupta 2018-08-31 204 return 0;
acce2633 Pankaj Gupta 2018-08-31 205 out_nd:
acce2633 Pankaj Gupta 2018-08-31 206 err = -ENXIO;
acce2633 Pankaj Gupta 2018-08-31 207 nvdimm_bus_unregister(nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 208 out_vq:
acce2633 Pankaj Gupta 2018-08-31 209 vdev->config->del_vqs(vdev);
acce2633 Pankaj Gupta 2018-08-31 210 out_err:
acce2633 Pankaj Gupta 2018-08-31 211 dev_err(&vdev->dev, "failed to register virtio pmem memory\n");
acce2633 Pankaj Gupta 2018-08-31 212 return err;
acce2633 Pankaj Gupta 2018-08-31 213 }
acce2633 Pankaj Gupta 2018-08-31 214
acce2633 Pankaj Gupta 2018-08-31 215 static void virtio_pmem_remove(struct virtio_device *vdev)
acce2633 Pankaj Gupta 2018-08-31 216 {
acce2633 Pankaj Gupta 2018-08-31 217 struct virtio_pmem *vpmem = vdev->priv;
acce2633 Pankaj Gupta 2018-08-31 218 struct nvdimm_bus *nvdimm_bus = dev_get_drvdata(&vdev->dev);
acce2633 Pankaj Gupta 2018-08-31 219
acce2633 Pankaj Gupta 2018-08-31 @220 nvdimm_bus_unregister(nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 221 vdev->config->del_vqs(vdev);
acce2633 Pankaj Gupta 2018-08-31 222 kfree(vpmem);
acce2633 Pankaj Gupta 2018-08-31 223 }
acce2633 Pankaj Gupta 2018-08-31 224
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, qemu-devel@nongnu.org,
linux-nvdimm@ml01.01.org, jack@suse.cz, stefanha@redhat.com,
dan.j.williams@intel.com, riel@surriel.com, nilal@redhat.com,
kwolf@redhat.com, pbonzini@redhat.com, ross.zwisler@intel.com,
david@redhat.com, xiaoguangrong.eric@gmail.com,
hch@infradead.org, mst@redhat.com, niteshnarayanlal@hotmail.com,
lcapitulino@redhat.com, imammedo@redhat.com, eblake@redhat.com,
pagupta@redhat.com
Subject: Re: [PATCH 3/3] virtio-pmem: Add virtio pmem driver
Date: Tue, 4 Sep 2018 23:17:00 +0800 [thread overview]
Message-ID: <20180904151700.GH17047@intel.com> (raw)
In-Reply-To: <20180831133019.27579-4-pagupta@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 6507 bytes --]
Hi Pankaj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v4.19-rc2 next-20180903]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pankaj-Gupta/kvm-fake-DAX-device/20180903-160032
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: i386-randconfig-a3-201835 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
All errors (new ones prefixed by >>):
drivers/virtio/virtio_pmem.o: In function `virtio_pmem_remove':
>> drivers/virtio/virtio_pmem.c:220: undefined reference to `nvdimm_bus_unregister'
drivers/virtio/virtio_pmem.o: In function `virtio_pmem_probe':
>> drivers/virtio/virtio_pmem.c:186: undefined reference to `nvdimm_bus_register'
>> drivers/virtio/virtio_pmem.c:198: undefined reference to `nvdimm_pmem_region_create'
drivers/virtio/virtio_pmem.c:207: undefined reference to `nvdimm_bus_unregister'
# https://github.com/0day-ci/linux/commit/acce2633da18b0ad58d0cc9243a85b03020ca099
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout acce2633da18b0ad58d0cc9243a85b03020ca099
vim +220 drivers/virtio/virtio_pmem.c
acce2633 Pankaj Gupta 2018-08-31 147
acce2633 Pankaj Gupta 2018-08-31 148 static int virtio_pmem_probe(struct virtio_device *vdev)
acce2633 Pankaj Gupta 2018-08-31 149 {
acce2633 Pankaj Gupta 2018-08-31 150 int err = 0;
acce2633 Pankaj Gupta 2018-08-31 151 struct resource res;
acce2633 Pankaj Gupta 2018-08-31 152 struct virtio_pmem *vpmem;
acce2633 Pankaj Gupta 2018-08-31 153 struct nvdimm_bus *nvdimm_bus;
acce2633 Pankaj Gupta 2018-08-31 154 struct nd_region_desc ndr_desc;
acce2633 Pankaj Gupta 2018-08-31 155 int nid = dev_to_node(&vdev->dev);
acce2633 Pankaj Gupta 2018-08-31 156 struct nd_region *nd_region;
acce2633 Pankaj Gupta 2018-08-31 157
acce2633 Pankaj Gupta 2018-08-31 158 if (!vdev->config->get) {
acce2633 Pankaj Gupta 2018-08-31 159 dev_err(&vdev->dev, "%s failure: config disabled\n",
acce2633 Pankaj Gupta 2018-08-31 160 __func__);
acce2633 Pankaj Gupta 2018-08-31 161 return -EINVAL;
acce2633 Pankaj Gupta 2018-08-31 162 }
acce2633 Pankaj Gupta 2018-08-31 163
acce2633 Pankaj Gupta 2018-08-31 164 vdev->priv = vpmem = devm_kzalloc(&vdev->dev, sizeof(*vpmem),
acce2633 Pankaj Gupta 2018-08-31 165 GFP_KERNEL);
acce2633 Pankaj Gupta 2018-08-31 166 if (!vpmem) {
acce2633 Pankaj Gupta 2018-08-31 167 err = -ENOMEM;
acce2633 Pankaj Gupta 2018-08-31 168 goto out_err;
acce2633 Pankaj Gupta 2018-08-31 169 }
acce2633 Pankaj Gupta 2018-08-31 170
acce2633 Pankaj Gupta 2018-08-31 171 vpmem->vdev = vdev;
acce2633 Pankaj Gupta 2018-08-31 172 err = init_vq(vpmem);
acce2633 Pankaj Gupta 2018-08-31 173 if (err)
acce2633 Pankaj Gupta 2018-08-31 174 goto out_err;
acce2633 Pankaj Gupta 2018-08-31 175
acce2633 Pankaj Gupta 2018-08-31 176 virtio_cread(vpmem->vdev, struct virtio_pmem_config,
acce2633 Pankaj Gupta 2018-08-31 177 start, &vpmem->start);
acce2633 Pankaj Gupta 2018-08-31 178 virtio_cread(vpmem->vdev, struct virtio_pmem_config,
acce2633 Pankaj Gupta 2018-08-31 179 size, &vpmem->size);
acce2633 Pankaj Gupta 2018-08-31 180
acce2633 Pankaj Gupta 2018-08-31 181 res.start = vpmem->start;
acce2633 Pankaj Gupta 2018-08-31 182 res.end = vpmem->start + vpmem->size-1;
acce2633 Pankaj Gupta 2018-08-31 183 vpmem->nd_desc.provider_name = "virtio-pmem";
acce2633 Pankaj Gupta 2018-08-31 184 vpmem->nd_desc.module = THIS_MODULE;
acce2633 Pankaj Gupta 2018-08-31 185
acce2633 Pankaj Gupta 2018-08-31 @186 vpmem->nvdimm_bus = nvdimm_bus = nvdimm_bus_register(&vdev->dev,
acce2633 Pankaj Gupta 2018-08-31 187 &vpmem->nd_desc);
acce2633 Pankaj Gupta 2018-08-31 188 if (!nvdimm_bus)
acce2633 Pankaj Gupta 2018-08-31 189 goto out_vq;
acce2633 Pankaj Gupta 2018-08-31 190
acce2633 Pankaj Gupta 2018-08-31 191 dev_set_drvdata(&vdev->dev, nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 192 memset(&ndr_desc, 0, sizeof(ndr_desc));
acce2633 Pankaj Gupta 2018-08-31 193
acce2633 Pankaj Gupta 2018-08-31 194 ndr_desc.res = &res;
acce2633 Pankaj Gupta 2018-08-31 195 ndr_desc.numa_node = nid;
acce2633 Pankaj Gupta 2018-08-31 196 ndr_desc.flush = virtio_pmem_flush;
acce2633 Pankaj Gupta 2018-08-31 197 set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags);
acce2633 Pankaj Gupta 2018-08-31 @198 nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc);
acce2633 Pankaj Gupta 2018-08-31 199
acce2633 Pankaj Gupta 2018-08-31 200 if (!nd_region)
acce2633 Pankaj Gupta 2018-08-31 201 goto out_nd;
acce2633 Pankaj Gupta 2018-08-31 202
acce2633 Pankaj Gupta 2018-08-31 203 //virtio_device_ready(vdev);
acce2633 Pankaj Gupta 2018-08-31 204 return 0;
acce2633 Pankaj Gupta 2018-08-31 205 out_nd:
acce2633 Pankaj Gupta 2018-08-31 206 err = -ENXIO;
acce2633 Pankaj Gupta 2018-08-31 207 nvdimm_bus_unregister(nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 208 out_vq:
acce2633 Pankaj Gupta 2018-08-31 209 vdev->config->del_vqs(vdev);
acce2633 Pankaj Gupta 2018-08-31 210 out_err:
acce2633 Pankaj Gupta 2018-08-31 211 dev_err(&vdev->dev, "failed to register virtio pmem memory\n");
acce2633 Pankaj Gupta 2018-08-31 212 return err;
acce2633 Pankaj Gupta 2018-08-31 213 }
acce2633 Pankaj Gupta 2018-08-31 214
acce2633 Pankaj Gupta 2018-08-31 215 static void virtio_pmem_remove(struct virtio_device *vdev)
acce2633 Pankaj Gupta 2018-08-31 216 {
acce2633 Pankaj Gupta 2018-08-31 217 struct virtio_pmem *vpmem = vdev->priv;
acce2633 Pankaj Gupta 2018-08-31 218 struct nvdimm_bus *nvdimm_bus = dev_get_drvdata(&vdev->dev);
acce2633 Pankaj Gupta 2018-08-31 219
acce2633 Pankaj Gupta 2018-08-31 @220 nvdimm_bus_unregister(nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 221 vdev->config->del_vqs(vdev);
acce2633 Pankaj Gupta 2018-08-31 222 kfree(vpmem);
acce2633 Pankaj Gupta 2018-08-31 223 }
acce2633 Pankaj Gupta 2018-08-31 224
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28663 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, qemu-devel@nongnu.org,
linux-nvdimm@ml01.01.org, jack@suse.cz, stefanha@redhat.com,
dan.j.williams@intel.com, riel@surriel.com, nilal@redhat.com,
kwolf@redhat.com, pbonzini@redhat.com, ross.zwisler@intel.com,
david@redhat.com, xiaoguangrong.eric@gmail.com,
hch@infradead.org, mst@redhat.com, niteshnarayanlal@hotmail.com,
lcapitulino@redhat.com, imammedo@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-pmem: Add virtio pmem driver
Date: Tue, 4 Sep 2018 23:17:00 +0800 [thread overview]
Message-ID: <20180904151700.GH17047@intel.com> (raw)
In-Reply-To: <20180831133019.27579-4-pagupta@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 6507 bytes --]
Hi Pankaj,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v4.19-rc2 next-20180903]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pankaj-Gupta/kvm-fake-DAX-device/20180903-160032
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-for-next
config: i386-randconfig-a3-201835 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
All errors (new ones prefixed by >>):
drivers/virtio/virtio_pmem.o: In function `virtio_pmem_remove':
>> drivers/virtio/virtio_pmem.c:220: undefined reference to `nvdimm_bus_unregister'
drivers/virtio/virtio_pmem.o: In function `virtio_pmem_probe':
>> drivers/virtio/virtio_pmem.c:186: undefined reference to `nvdimm_bus_register'
>> drivers/virtio/virtio_pmem.c:198: undefined reference to `nvdimm_pmem_region_create'
drivers/virtio/virtio_pmem.c:207: undefined reference to `nvdimm_bus_unregister'
# https://github.com/0day-ci/linux/commit/acce2633da18b0ad58d0cc9243a85b03020ca099
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout acce2633da18b0ad58d0cc9243a85b03020ca099
vim +220 drivers/virtio/virtio_pmem.c
acce2633 Pankaj Gupta 2018-08-31 147
acce2633 Pankaj Gupta 2018-08-31 148 static int virtio_pmem_probe(struct virtio_device *vdev)
acce2633 Pankaj Gupta 2018-08-31 149 {
acce2633 Pankaj Gupta 2018-08-31 150 int err = 0;
acce2633 Pankaj Gupta 2018-08-31 151 struct resource res;
acce2633 Pankaj Gupta 2018-08-31 152 struct virtio_pmem *vpmem;
acce2633 Pankaj Gupta 2018-08-31 153 struct nvdimm_bus *nvdimm_bus;
acce2633 Pankaj Gupta 2018-08-31 154 struct nd_region_desc ndr_desc;
acce2633 Pankaj Gupta 2018-08-31 155 int nid = dev_to_node(&vdev->dev);
acce2633 Pankaj Gupta 2018-08-31 156 struct nd_region *nd_region;
acce2633 Pankaj Gupta 2018-08-31 157
acce2633 Pankaj Gupta 2018-08-31 158 if (!vdev->config->get) {
acce2633 Pankaj Gupta 2018-08-31 159 dev_err(&vdev->dev, "%s failure: config disabled\n",
acce2633 Pankaj Gupta 2018-08-31 160 __func__);
acce2633 Pankaj Gupta 2018-08-31 161 return -EINVAL;
acce2633 Pankaj Gupta 2018-08-31 162 }
acce2633 Pankaj Gupta 2018-08-31 163
acce2633 Pankaj Gupta 2018-08-31 164 vdev->priv = vpmem = devm_kzalloc(&vdev->dev, sizeof(*vpmem),
acce2633 Pankaj Gupta 2018-08-31 165 GFP_KERNEL);
acce2633 Pankaj Gupta 2018-08-31 166 if (!vpmem) {
acce2633 Pankaj Gupta 2018-08-31 167 err = -ENOMEM;
acce2633 Pankaj Gupta 2018-08-31 168 goto out_err;
acce2633 Pankaj Gupta 2018-08-31 169 }
acce2633 Pankaj Gupta 2018-08-31 170
acce2633 Pankaj Gupta 2018-08-31 171 vpmem->vdev = vdev;
acce2633 Pankaj Gupta 2018-08-31 172 err = init_vq(vpmem);
acce2633 Pankaj Gupta 2018-08-31 173 if (err)
acce2633 Pankaj Gupta 2018-08-31 174 goto out_err;
acce2633 Pankaj Gupta 2018-08-31 175
acce2633 Pankaj Gupta 2018-08-31 176 virtio_cread(vpmem->vdev, struct virtio_pmem_config,
acce2633 Pankaj Gupta 2018-08-31 177 start, &vpmem->start);
acce2633 Pankaj Gupta 2018-08-31 178 virtio_cread(vpmem->vdev, struct virtio_pmem_config,
acce2633 Pankaj Gupta 2018-08-31 179 size, &vpmem->size);
acce2633 Pankaj Gupta 2018-08-31 180
acce2633 Pankaj Gupta 2018-08-31 181 res.start = vpmem->start;
acce2633 Pankaj Gupta 2018-08-31 182 res.end = vpmem->start + vpmem->size-1;
acce2633 Pankaj Gupta 2018-08-31 183 vpmem->nd_desc.provider_name = "virtio-pmem";
acce2633 Pankaj Gupta 2018-08-31 184 vpmem->nd_desc.module = THIS_MODULE;
acce2633 Pankaj Gupta 2018-08-31 185
acce2633 Pankaj Gupta 2018-08-31 @186 vpmem->nvdimm_bus = nvdimm_bus = nvdimm_bus_register(&vdev->dev,
acce2633 Pankaj Gupta 2018-08-31 187 &vpmem->nd_desc);
acce2633 Pankaj Gupta 2018-08-31 188 if (!nvdimm_bus)
acce2633 Pankaj Gupta 2018-08-31 189 goto out_vq;
acce2633 Pankaj Gupta 2018-08-31 190
acce2633 Pankaj Gupta 2018-08-31 191 dev_set_drvdata(&vdev->dev, nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 192 memset(&ndr_desc, 0, sizeof(ndr_desc));
acce2633 Pankaj Gupta 2018-08-31 193
acce2633 Pankaj Gupta 2018-08-31 194 ndr_desc.res = &res;
acce2633 Pankaj Gupta 2018-08-31 195 ndr_desc.numa_node = nid;
acce2633 Pankaj Gupta 2018-08-31 196 ndr_desc.flush = virtio_pmem_flush;
acce2633 Pankaj Gupta 2018-08-31 197 set_bit(ND_REGION_PAGEMAP, &ndr_desc.flags);
acce2633 Pankaj Gupta 2018-08-31 @198 nd_region = nvdimm_pmem_region_create(nvdimm_bus, &ndr_desc);
acce2633 Pankaj Gupta 2018-08-31 199
acce2633 Pankaj Gupta 2018-08-31 200 if (!nd_region)
acce2633 Pankaj Gupta 2018-08-31 201 goto out_nd;
acce2633 Pankaj Gupta 2018-08-31 202
acce2633 Pankaj Gupta 2018-08-31 203 //virtio_device_ready(vdev);
acce2633 Pankaj Gupta 2018-08-31 204 return 0;
acce2633 Pankaj Gupta 2018-08-31 205 out_nd:
acce2633 Pankaj Gupta 2018-08-31 206 err = -ENXIO;
acce2633 Pankaj Gupta 2018-08-31 207 nvdimm_bus_unregister(nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 208 out_vq:
acce2633 Pankaj Gupta 2018-08-31 209 vdev->config->del_vqs(vdev);
acce2633 Pankaj Gupta 2018-08-31 210 out_err:
acce2633 Pankaj Gupta 2018-08-31 211 dev_err(&vdev->dev, "failed to register virtio pmem memory\n");
acce2633 Pankaj Gupta 2018-08-31 212 return err;
acce2633 Pankaj Gupta 2018-08-31 213 }
acce2633 Pankaj Gupta 2018-08-31 214
acce2633 Pankaj Gupta 2018-08-31 215 static void virtio_pmem_remove(struct virtio_device *vdev)
acce2633 Pankaj Gupta 2018-08-31 216 {
acce2633 Pankaj Gupta 2018-08-31 217 struct virtio_pmem *vpmem = vdev->priv;
acce2633 Pankaj Gupta 2018-08-31 218 struct nvdimm_bus *nvdimm_bus = dev_get_drvdata(&vdev->dev);
acce2633 Pankaj Gupta 2018-08-31 219
acce2633 Pankaj Gupta 2018-08-31 @220 nvdimm_bus_unregister(nvdimm_bus);
acce2633 Pankaj Gupta 2018-08-31 221 vdev->config->del_vqs(vdev);
acce2633 Pankaj Gupta 2018-08-31 222 kfree(vpmem);
acce2633 Pankaj Gupta 2018-08-31 223 }
acce2633 Pankaj Gupta 2018-08-31 224
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28663 bytes --]
next prev parent reply other threads:[~2018-09-04 15:17 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 13:30 [PATCH 0/3] kvm "fake DAX" device Pankaj Gupta
2018-08-31 13:30 ` [Qemu-devel] " Pankaj Gupta
2018-08-31 13:30 ` Pankaj Gupta
[not found] ` <20180831133019.27579-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-31 13:30 ` [PATCH 1/3] nd: move nd_region to common header Pankaj Gupta
2018-08-31 13:30 ` [Qemu-devel] " Pankaj Gupta
2018-08-31 13:30 ` Pankaj Gupta
[not found] ` <20180831133019.27579-2-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-22 0:47 ` Dan Williams
2018-09-22 0:47 ` Dan Williams
[not found] ` <CAPcyv4jFimkVnVuzza5TCG=KvY88KZnXzH4GNEgUBbTouprzJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-24 11:40 ` Pankaj Gupta
2018-09-24 11:40 ` Pankaj Gupta
2018-08-31 13:30 ` [PATCH 2/3] libnvdimm: nd_region flush callback support Pankaj Gupta
2018-08-31 13:30 ` [Qemu-devel] " Pankaj Gupta
2018-08-31 13:30 ` Pankaj Gupta
2018-09-04 15:29 ` kbuild test robot
2018-09-04 15:29 ` [Qemu-devel] " kbuild test robot
2018-09-04 15:29 ` kbuild test robot
[not found] ` <20180904152917.GE17047-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2018-09-05 8:40 ` Pankaj Gupta
2018-09-05 8:40 ` [Qemu-devel] " Pankaj Gupta
2018-09-05 8:40 ` Pankaj Gupta
2018-09-22 0:43 ` Dan Williams
2018-09-24 11:07 ` Pankaj Gupta
2018-08-31 13:30 ` [PATCH 3/3] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2018-08-31 13:30 ` [Qemu-devel] " Pankaj Gupta
2018-08-31 13:30 ` Pankaj Gupta
[not found] ` <20180831133019.27579-4-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-04 15:17 ` kbuild test robot [this message]
2018-09-04 15:17 ` [Qemu-devel] " kbuild test robot
2018-09-04 15:17 ` kbuild test robot
2018-09-05 8:34 ` Pankaj Gupta
2018-09-05 8:34 ` [Qemu-devel] " Pankaj Gupta
2018-09-05 12:02 ` kbuild test robot
2018-09-05 12:02 ` [Qemu-devel] " kbuild test robot
2018-09-05 12:02 ` kbuild test robot
2018-09-12 16:54 ` Luiz Capitulino
2018-09-12 16:54 ` [Qemu-devel] " Luiz Capitulino
2018-09-12 16:54 ` Luiz Capitulino
2018-09-13 6:58 ` [Qemu-devel] " Pankaj Gupta
2018-09-13 6:58 ` Pankaj Gupta
[not found] ` <831225077.12817716.1536821901550.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-13 12:19 ` Luiz Capitulino
2018-09-13 12:19 ` Luiz Capitulino
2018-09-14 12:13 ` Pankaj Gupta
2018-09-22 1:08 ` Dan Williams
2018-09-22 1:08 ` Dan Williams
2018-09-24 9:41 ` Pankaj Gupta
2018-09-27 13:06 ` Pankaj Gupta
2018-09-27 15:55 ` Dan Williams
2018-08-31 13:30 ` [PATCH] qemu: Add virtio pmem device Pankaj Gupta
2018-08-31 13:30 ` [Qemu-devel] " Pankaj Gupta
2018-08-31 13:30 ` Pankaj Gupta
[not found] ` <20180831133019.27579-5-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-12 16:57 ` Luiz Capitulino
2018-09-12 16:57 ` [Qemu-devel] " Luiz Capitulino
2018-09-12 16:57 ` Luiz Capitulino
2018-09-13 7:06 ` Pankaj Gupta
2018-09-13 7:06 ` [Qemu-devel] " Pankaj Gupta
2018-09-13 7:06 ` Pankaj Gupta
[not found] ` <563893075.12819183.1536822387535.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-13 12:22 ` Luiz Capitulino
2018-09-13 12:22 ` [Qemu-devel] " Luiz Capitulino
2018-09-13 12:22 ` Luiz Capitulino
2018-09-20 11:21 ` David Hildenbrand
[not found] ` <2721c3ee-88d1-a8e9-1f1e-ffc3eef1d1ca-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-09-20 12:03 ` [Qemu-devel] " Pankaj Gupta
2018-09-20 12:03 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904151700.GH17047@intel.com \
--to=lkp-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eblake-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=imammedo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=kbuild-all-JC7UmRfGjtg@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=lcapitulino-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \
--cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nilal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=niteshnarayanlal-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org \
--cc=pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
--cc=riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org \
--cc=ross.zwisler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=stefanha-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.