From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9832FC43334 for ; Tue, 4 Sep 2018 15:38:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D0C4206BA for ; Tue, 4 Sep 2018 15:38:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D0C4206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727864AbeIDUEK (ORCPT ); Tue, 4 Sep 2018 16:04:10 -0400 Received: from muru.com ([72.249.23.125]:55244 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727533AbeIDUEJ (ORCPT ); Tue, 4 Sep 2018 16:04:09 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4306C80E1; Tue, 4 Sep 2018 15:42:30 +0000 (UTC) Date: Tue, 4 Sep 2018 08:38:28 -0700 From: Tony Lindgren To: Ulf Hansson Cc: Andreas Kemnade , Kishon , Wolfram Sang , "linux-mmc@vger.kernel.org" , linux-omap , Linux Kernel Mailing List , Discussions about the Letux Kernel Subject: Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal Message-ID: <20180904153828.GC5662@atomide.com> References: <20180902073058.17053-1-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ulf Hansson [180904 14:39]: > On 2 September 2018 at 09:30, Andreas Kemnade wrote: > > after unbinding mmc I get things like this: > > [ 185.294067] mmc1: card 0001 removed > > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13 > > > > The wakeirq stays in /proc-interrupts > > > > rebinding shows this: > > [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup) > > [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ > > [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling > > > > That bug seems to be introduced by switching from devm_request_irq() > > to generic wakeirq handling. > > > > So let us cleanup at removal. > > > > Signed-off-by: Andreas Kemnade > > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq") Ooops sorry about that. > Applied for fixes, and added a stable tag, thanks! OK and thanks for fixing this Andreas! Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] mmc: omap_hsmmc: fix wakeirq handling on removal Date: Tue, 4 Sep 2018 08:38:28 -0700 Message-ID: <20180904153828.GC5662@atomide.com> References: <20180902073058.17053-1-andreas@kemnade.info> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson Cc: Andreas Kemnade , Kishon , Wolfram Sang , "linux-mmc@vger.kernel.org" , linux-omap , Linux Kernel Mailing List , Discussions about the Letux Kernel List-Id: linux-mmc@vger.kernel.org * Ulf Hansson [180904 14:39]: > On 2 September 2018 at 09:30, Andreas Kemnade wrote: > > after unbinding mmc I get things like this: > > [ 185.294067] mmc1: card 0001 removed > > [ 185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13 > > > > The wakeirq stays in /proc-interrupts > > > > rebinding shows this: > > [ 289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup) > > [ 289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ > > [ 289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling > > > > That bug seems to be introduced by switching from devm_request_irq() > > to generic wakeirq handling. > > > > So let us cleanup at removal. > > > > Signed-off-by: Andreas Kemnade > > Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq") Ooops sorry about that. > Applied for fixes, and added a stable tag, thanks! OK and thanks for fixing this Andreas! Regards, Tony