From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F39A4C433F5 for ; Tue, 4 Sep 2018 15:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B77BE20843 for ; Tue, 4 Sep 2018 15:46:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B77BE20843 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727527AbeIDULk (ORCPT ); Tue, 4 Sep 2018 16:11:40 -0400 Received: from mga18.intel.com ([134.134.136.126]:24310 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeIDULk (ORCPT ); Tue, 4 Sep 2018 16:11:40 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2018 08:45:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,329,1531810800"; d="scan'208";a="80787747" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.20]) by orsmga003.jf.intel.com with ESMTP; 04 Sep 2018 08:45:53 -0700 Date: Tue, 4 Sep 2018 08:45:53 -0700 From: Sean Christopherson To: Jarkko Sakkinen Cc: Andy Shevchenko , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , Dave Hansen , nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , suresh.b.siddha@intel.com, serge.ayoun@intel.com, Linux Kernel Mailing List Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Message-ID: <20180904154553.GA5412@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <20180904153803.GC8344@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180904153803.GC8344@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 06:38:03PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > > > > > > + WARN(ret < 0, "sgx: cannot free page, reclaim in-progress"); > > > + WARN(ret > 0, "sgx: EREMOVE returned %d (0x%x)", ret, ret); > > > > I'm not sure (though it's easy to check) that you need sgx: prefix > > here. WARN() might take pr_fmt() if defined. > > Sean, you took care of this one. Was it so that WARN() does not respect > pr_fmt? Yep, WARN() doesn't respect pr_fmt. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com ([134.134.136.126]:24310 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeIDULk (ORCPT ); Tue, 4 Sep 2018 16:11:40 -0400 Date: Tue, 4 Sep 2018 08:45:53 -0700 From: Sean Christopherson To: Jarkko Sakkinen CC: Andy Shevchenko , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , Dave Hansen , , , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , , , Linux Kernel Mailing List Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Message-ID: <20180904154553.GA5412@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <20180904153803.GC8344@linux.intel.com> Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20180904153803.GC8344@linux.intel.com> Sender: List-ID: Return-Path: linux-sgx-owner@vger.kernel.org MIME-Version: 1.0 On Tue, Sep 04, 2018 at 06:38:03PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > > > > > > + WARN(ret < 0, "sgx: cannot free page, reclaim in-progress"); > > > + WARN(ret > 0, "sgx: EREMOVE returned %d (0x%x)", ret, ret); > > > > I'm not sure (though it's easy to check) that you need sgx: prefix > > here. WARN() might take pr_fmt() if defined. > > Sean, you took care of this one. Was it so that WARN() does not respect > pr_fmt? Yep, WARN() doesn't respect pr_fmt.