From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96613C43334 for ; Tue, 4 Sep 2018 16:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3980420645 for ; Tue, 4 Sep 2018 16:03:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3980420645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbeIDU3c (ORCPT ); Tue, 4 Sep 2018 16:29:32 -0400 Received: from mail.skyhub.de ([5.9.137.197]:50794 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbeIDU3c (ORCPT ); Tue, 4 Sep 2018 16:29:32 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BfeHb0tIOo_A; Tue, 4 Sep 2018 18:03:28 +0200 (CEST) Received: from zn.tnic (p200300EC2BC9A500329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bc9:a500:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 99E631EC0181; Tue, 4 Sep 2018 18:03:16 +0200 (CEST) Date: Tue, 4 Sep 2018 18:03:10 +0200 From: Borislav Petkov To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com, helgaas@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support Message-ID: <20180904160310.GJ32615@zn.tnic> References: <20180904145255.GI32615@zn.tnic> <5c6b1493-ee20-ed3f-a558-331c0cb65556@hygon.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5c6b1493-ee20-ed3f-a558-331c0cb65556@hygon.cn> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 11:45:02PM +0800, Pu Wen wrote: > I add these definitions to indicate that there are Hygon PCI device IDs. > You are right, I can just use the AMD f17h ones here. Right, if this is a small piece where they're all together in a single compilation unit - like in this case - I don't see an issue with using the AMD ones. Later, when you start splitting functionality, you can do proper defines. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.