All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH i-g-t] igt/pm_rpm: Reload the module with full mmio debugging
Date: Tue,  4 Sep 2018 17:07:40 +0100	[thread overview]
Message-ID: <20180904160740.20722-1-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20180904102004.5726-1-chris@chris-wilson.co.uk>

Our unclaimed mmio access debugging is lazy, doing cheap checks
periodically and only if they fail do a full check around every mmio
access. When testing for runtime pm, enable the full mmio debugging from
the initial load.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
---
 tests/pm_rpm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index e3bb6227a..c24fd95bb 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -2058,7 +2058,7 @@ int main(int argc, char *argv[])
 	igt_subtest("module-reload") {
 		igt_debug("Reload w/o display\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
+		igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=-1"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
@@ -2066,13 +2066,16 @@ int main(int argc, char *argv[])
 
 		igt_debug("Reload as normal\n");
 		igt_i915_driver_unload();
-		igt_assert_eq(igt_i915_driver_load(NULL), 0);
+		igt_assert_eq(igt_i915_driver_load("mmio_debug=-1"), 0);
 
 		igt_assert(setup_environment());
 		igt_assert(igt_wait(device_in_pci_d3(), 2000, 100));
 		if (enable_one_screen_with_type(&ms_data, SCREEN_TYPE_ANY))
 			drm_resources_equal_subtest();
 		teardown_environment();
+
+		/* Remove our mmio_debugging module */
+		igt_i915_driver_unload();
 	}
 
 	igt_exit();
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-09-04 16:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 10:20 [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging Chris Wilson
2018-09-04 10:20 ` [igt-dev] " Chris Wilson
2018-09-04 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/pm_rpm: Reload the module with full mmio debugging (rev2) Patchwork
2018-09-04 11:12   ` Chris Wilson
2018-09-04 14:14 ` [PATCH i-g-t] lib/pm_rpm: Reload the module with full mmio debugging Imre Deak
2018-09-04 14:14   ` [Intel-gfx] " Imre Deak
2018-09-04 14:21   ` Chris Wilson
2018-09-04 14:21     ` [igt-dev] " Chris Wilson
2018-09-04 14:50     ` Imre Deak
2018-09-04 14:50       ` [igt-dev] " Imre Deak
2018-09-04 16:07 ` Chris Wilson [this message]
2018-09-04 16:38 ` ✓ Fi.CI.BAT: success for igt/pm_rpm: " Patchwork
2018-09-04 23:11 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-06 13:49 ` [igt-dev] ✓ Fi.CI.IGT: success for lib/pm_rpm: Reload the module with full mmio debugging (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904160740.20722-1-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.