From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Be defensive and don't assume PSR has any commit to sync against Date: Tue, 4 Sep 2018 21:06:29 +0300 Message-ID: <20180904180629.GK5565@intel.com> References: <20180904162902.2578-1-chris@chris-wilson.co.uk> <20180904173953.GI5565@intel.com> <153608305453.2853.15799668426378990226@skylake-alporthouse-com> <20180904175932.GJ5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A7A289BBD for ; Tue, 4 Sep 2018 18:08:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180904175932.GJ5565@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDg6NTk6MzJQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgU2VwIDA0LCAyMDE4IGF0IDA2OjQ0OjE0UE0gKzAxMDAsIENocmlz IFdpbHNvbiB3cm90ZToKPiA+IFF1b3RpbmcgVmlsbGUgU3lyasOkbMOkICgyMDE4LTA5LTA0IDE4 OjM5OjUzKQo+ID4gPiBPbiBUdWUsIFNlcCAwNCwgMjAxOCBhdCAwNToyOTowMlBNICswMTAwLCBD aHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+ID4gSWYgdGhlIHByZXZpb3VzIG1vZGVzZXQgY29tbWl0 IGhhcyBjb21wbGV0ZWQgYW5kIGlzIG5vIGxvbmdlciBwYXJ0IG9mCj4gPiA+ID4gdGhlIGNydGMg c3RhdGUsIHNraXAgd2FpdGluZyBmb3IgaXQuCj4gPiA+ID4gCj4gPiA+ID4gQnVnemlsbGE6IGh0 dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzc5Mgo+ID4gPiA+ IEZpeGVzOiBjNDQzMDFmY2U2MTQgKCJkcm0vaTkxNTogQWxsb3cgY29udHJvbCBvZiBQU1IgYXQg cnVudGltZSB0aHJvdWdoIGRlYnVnZnMsIHY2IikKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+ID4gPiBDYzogTWFhcnRlbiBM YW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gPiBDYzog Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gPiA+IENjOiBEaGluYWth cmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiA+ID4gPiAtLS0K PiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgfCAxNiArKysrKysrKysr LS0tLS0tCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0 aW9ucygtKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+ID4g aW5kZXggMjE5ODRkNGMwOGVkLi5iZGRjOWM3YzY4MWUgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiA+IEBAIC04MzQsNiArODM0LDcgQEAgaW50IGludGVs X3Bzcl9zZXRfZGVidWdmc19tb2RlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiA+ID4gPiAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gJmRldl9wcml2LT5kcm07Cj4g PiA+ID4gICAgICAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4gPiA+ ID4gICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPSBOVUxMOwo+ID4g PiA+ICsgICAgIHN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNvbW1pdCA9IE5VTEw7Cj4gPiA+ID4g ICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4gPiA+ICAgICAgIHN0cnVjdCBpbnRlbF9k cCAqZHA7Cj4gPiA+ID4gICAgICAgaW50IHJldDsKPiA+ID4gPiBAQCAtODYwLDEyICs4NjEsMTUg QEAgaW50IGludGVsX3Bzcl9zZXRfZGVidWdmc19tb2RlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiA+ ID4gPiAgCj4gPiA+ID4gICAgICAgICAgICAgICBjcnRjX3N0YXRlID0gdG9faW50ZWxfY3J0Y19z dGF0ZShjcnRjLT5zdGF0ZSk7Cj4gPiA+ID4gLSAgICAgICAgICAgICByZXQgPSB3YWl0X2Zvcl9j b21wbGV0aW9uX2ludGVycnVwdGlibGUoJmNydGNfc3RhdGUtPmJhc2UuY29tbWl0LT5od19kb25l KTsKPiA+ID4gPiAtICAgICB9IGVsc2UKPiA+ID4gPiAtICAgICAgICAgICAgIHJldCA9IHdhaXRf Zm9yX2NvbXBsZXRpb25faW50ZXJydXB0aWJsZSgmY29ubl9zdGF0ZS0+Y29tbWl0LT5od19kb25l KTsKPiA+ID4gPiAtCj4gPiA+ID4gLSAgICAgaWYgKHJldCkKPiA+ID4gPiAtICAgICAgICAgICAg IHJldHVybiByZXQ7Cj4gPiA+ID4gKyAgICAgICAgICAgICBjb21taXQgPSBjcnRjX3N0YXRlLT5i YXNlLmNvbW1pdDsKPiA+ID4gPiArICAgICB9IGVsc2Ugewo+ID4gPiA+ICsgICAgICAgICAgICAg Y29tbWl0ID0gY29ubl9zdGF0ZS0+Y29tbWl0Owo+ID4gPiAKPiA+ID4gSSBjYW4ndCBldmVuIGZp bmQgd2hlcmUgd2UgY2xlYXIgc3RhdGUtPmNvbW1pdCBhZnRlciBpdHMgZG9uZS4KPiA+ID4gRG8g d2UganVzdCBsZWF2ZSBpdCBwb2ludGluZyBhdCBmcmVlZCBtZW1vcnkgb3Igc29tZXRoaW5nPyBB bHNvIEkKPiA+ID4gY2FuJ3QgZmlndXJlIG91dCB3aHkgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0 X2h3X2RvbmUoKSBjb3BpZXMKPiA+ID4gdGhlIGNvbW1pdCBhbHNvIHRvIHRoZSBvbGQgc3RhdGUu Cj4gPiAKPiA+IExldCBtZSBiZSB0aGUgbWVzc2VuZ2VyIHRoZW4gOykgY29tbWl0IGlzIE5VTEwg YXQgdGhpcyBwb2ludCwgSSBqdXN0Cj4gPiBwcmVzdW1lZCBpdCB3YXMgaW50ZW50aW9uYWwuCj4g Cj4gTXkgZXhwZWN0YXRpb24gd291bGQgYmUgdGhhdCBpdCBnZXRzIGNsZWFyZWQgc29tZXdoZXJl LCBidXQgSSBzaW1wbHkKPiBjYW4ndCBmaW5kIGFueSBzdWNoIGNvZGUuCgpBY3R1YWxseSBpdCBs b29rcyBsaWtlIHRoZXJlIGlzIG5vIHN1Y2ggY29kZS4gVGhlIGV2ZW50IGJhc2VkCnJlbGVhc2Vf Y3J0Y19jb21taXQoKSB0aGluZyBnZXRzIGl0cyBvd24gcmVmZXJlbmNlIHNvIHByZXN1bWFibHkg dGhlCm9yaWdpbmFsIHJlZmVyZW5jZSBzdGF5cyB3aXRoIHRoZSBzdGF0ZSB1bnRpbCB0aGUgc3Rh dGUgaXRzZWxmIGdldHMKZGVzdHJveWVkLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK