From: Gerd Hoffmann <kraxel@redhat.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: "Michel Dänzer" <michel@daenzer.net>,
"David Airlie" <airlied@linux.ie>, "Sean Paul" <sean@poorly.run>,
dri-devel <dri-devel@lists.freedesktop.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines.
Date: Wed, 5 Sep 2018 08:10:41 +0200 [thread overview]
Message-ID: <20180905061041.7yfmvnpbnbugboc4@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAKb7UvhwQ3h8d2t+-Cqd675oJSffyQrBG4SB1UqMSX82SDXs1g@mail.gmail.com>
Hi,
> >>> As explained before, that would break radeon userspace on big endian hosts.
> >>
> >> We last discussed this about a year ago, so I hope you'll forgive my
> >> lapse in memory...
> >>
> >> There's userspace that uses ADDFB2 with DRM_FORMAT_XRGB8888 but
> >> expects it to be host-endian?
> >
> > ADDFB, not ADDFB2. The latter probably didn't even exist yet when this
> > was made to work. :)
>
> Right, but ADDFB doesn't know or care about DRM_FORMAT_*. That's what
> I'm saying -- keep ADDFB working, and fix up the DRM_FORMAT_*
> underneath it both in the conversion and in the driver. Gerd's patch
> allows us to do this incrementally, eventually truing up the
> DRM_FORMAT_* in the driver, enabling ADDFB2 to work as expected.
If it is that simple then yes, we should be able to fix the radeon kms
driver, then drop the quirk once all kms drivers are fixed.
But IIRC there are some radeon-sepcific calls used by the radeon xorg
driver affected too (thats why the commit message says "... both xorg and
kernel drivers ..."), so fixing it for radeon isn't that easy ...
cheers,
Gerd
next prev parent reply other threads:[~2018-09-05 6:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 10:57 [PATCH 0/5] drm: byteorder fixes Gerd Hoffmann
2018-09-03 10:57 ` [PATCH 1/5] drm: byteorder: add DRM_FORMAT_HOST_* Gerd Hoffmann
2018-09-03 10:57 ` Gerd Hoffmann
2018-09-03 10:57 ` [PATCH 2/5] drm: do not mask out DRM_FORMAT_BIG_ENDIAN Gerd Hoffmann
2018-09-03 10:57 ` Gerd Hoffmann
2018-09-03 10:57 ` [PATCH 3/5] drm: fix drm_mode_addfb() on big endian machines Gerd Hoffmann
2018-09-03 10:57 ` Gerd Hoffmann
2018-09-03 16:45 ` Daniel Vetter
2018-09-03 17:01 ` Michel Dänzer
2018-09-03 17:01 ` Michel Dänzer
2018-09-03 17:07 ` Ilia Mirkin
2018-09-04 8:00 ` Michel Dänzer
2018-09-04 8:00 ` Michel Dänzer
2018-09-04 13:05 ` Ilia Mirkin
2018-09-04 13:05 ` Ilia Mirkin
2018-09-04 15:02 ` Michel Dänzer
2018-09-04 15:02 ` Michel Dänzer
2018-09-04 15:15 ` Ilia Mirkin
2018-09-04 15:15 ` Ilia Mirkin
2018-09-05 6:10 ` Gerd Hoffmann [this message]
2018-09-03 10:57 ` [PATCH 4/5] drm/bochs: fix DRM_FORMAT_* handling for " Gerd Hoffmann
2018-09-03 10:57 ` Gerd Hoffmann
2018-09-03 10:57 ` [PATCH 5/5] drm/virtio: fix DRM_FORMAT_* handling Gerd Hoffmann
2018-09-03 10:57 ` Gerd Hoffmann
2018-09-03 10:57 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905061041.7yfmvnpbnbugboc4@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=imirkin@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.