From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com
Subject: [Qemu-devel] [PATCH v8 5/6] tests: add oob functional test for test-qmp-cmds
Date: Wed, 5 Sep 2018 14:23:12 +0800 [thread overview]
Message-ID: <20180905062313.4059-6-peterx@redhat.com> (raw)
In-Reply-To: <20180905062313.4059-1-peterx@redhat.com>
Straightforward test just to let the test-qmp-cmds be complete.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/test-qmp-cmds.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
index ab414fa0c9..23c68c7944 100644
--- a/tests/test-qmp-cmds.c
+++ b/tests/test-qmp-cmds.c
@@ -122,6 +122,21 @@ static void test_dispatch_cmd(void)
qobject_unref(req);
}
+static void test_dispatch_cmd_oob(void)
+{
+ QDict *req = qdict_new();
+ QDict *resp;
+
+ qdict_put_str(req, "exec-oob", "test-flags-command");
+
+ resp = qmp_dispatch(&qmp_commands, QOBJECT(req), true);
+ assert(resp != NULL);
+ assert(!qdict_haskey(resp, "error"));
+
+ qobject_unref(resp);
+ qobject_unref(req);
+}
+
/* test commands that return an error due to invalid parameters */
static void test_dispatch_cmd_failure(void)
{
@@ -287,6 +302,7 @@ int main(int argc, char **argv)
g_test_init(&argc, &argv, NULL);
g_test_add_func("/qmp/dispatch_cmd", test_dispatch_cmd);
+ g_test_add_func("/qmp/dispatch_cmd_oob", test_dispatch_cmd_oob);
g_test_add_func("/qmp/dispatch_cmd_failure", test_dispatch_cmd_failure);
g_test_add_func("/qmp/dispatch_cmd_io", test_dispatch_cmd_io);
g_test_add_func("/qmp/dealloc_types", test_dealloc_types);
--
2.17.1
next prev parent reply other threads:[~2018-09-05 6:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 6:23 [Qemu-devel] [PATCH v8 0/6] monitor: enable OOB by default Peter Xu
2018-09-05 6:23 ` [Qemu-devel] [PATCH v8 1/6] monitor: Suspend monitor instead dropping commands Peter Xu
2018-09-05 6:23 ` [Qemu-devel] [PATCH v8 2/6] monitor: resume the monitor earlier if needed Peter Xu
[not found] ` <CAJ+F1CJJB2ZyTQ3OBJ+c49bqZMWSKqfp7UOoM7QBEhH6Exnsbg@mail.gmail.com>
[not found] ` <20180929040529.GQ9560@xz-x1>
2018-10-02 9:13 ` Marc-André Lureau
2018-10-08 7:15 ` Peter Xu
2018-10-09 12:26 ` Marc-André Lureau
2018-09-05 6:23 ` [Qemu-devel] [PATCH v8 3/6] monitor: remove "x-oob", turn oob on by default Peter Xu
2018-09-05 6:23 ` [Qemu-devel] [PATCH v8 4/6] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Peter Xu
2018-09-05 6:23 ` Peter Xu [this message]
2018-09-05 6:23 ` [Qemu-devel] [PATCH v8 6/6] tests: qmp-test: add queue full test Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905062313.4059-6-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.