From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Be defensive and don't assume PSR has any commit to sync against Date: Wed, 5 Sep 2018 13:22:00 +0300 Message-ID: <20180905102200.GM5565@intel.com> References: <20180904162902.2578-1-chris@chris-wilson.co.uk> <20180904173953.GI5565@intel.com> <153608305453.2853.15799668426378990226@skylake-alporthouse-com> <20180904175932.GJ5565@intel.com> <20180904180629.GK5565@intel.com> <153608476616.2853.7336345533645014202@skylake-alporthouse-com> <6e1e3faeb3372faf9d9d412ec776277fb4c26547.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BE2E6E0B3 for ; Wed, 5 Sep 2018 10:22:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <6e1e3faeb3372faf9d9d412ec776277fb4c26547.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDg6NTQ6MDNQTSArMDAwMCwgUGFuZGl5YW4sIERoaW5h a2FyYW4gd3JvdGU6Cj4gT24gVHVlLCAyMDE4LTA5LTA0IGF0IDE5OjEyICswMTAwLCBDaHJpcyBX aWxzb24gd3JvdGU6Cj4gPiBRdW90aW5nIFZpbGxlIFN5cmrDpGzDpCAoMjAxOC0wOS0wNCAxOTow NjoyOSkKPiA+ID4gT24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDg6NTk6MzJQTSArMDMwMCwgVmls bGUgU3lyasOkbMOkIHdyb3RlOgo+ID4gPiA+IE9uIFR1ZSwgU2VwIDA0LCAyMDE4IGF0IDA2OjQ0 OjE0UE0gKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+ID4gPiA+IFF1b3RpbmcgVmlsbGUg U3lyasOkbMOkICgyMDE4LTA5LTA0IDE4OjM5OjUzKQo+ID4gPiA+ID4gPiBPbiBUdWUsIFNlcCAw NCwgMjAxOCBhdCAwNToyOTowMlBNICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+ID4g PiA+ID4gSWYgdGhlIHByZXZpb3VzIG1vZGVzZXQgY29tbWl0IGhhcyBjb21wbGV0ZWQgYW5kIGlz IG5vCj4gPiA+ID4gPiA+ID4gbG9uZ2VyIHBhcnQgb2YKPiA+ID4gPiA+ID4gPiB0aGUgY3J0YyBz dGF0ZSwgc2tpcCB3YWl0aW5nIGZvciBpdC4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBC dWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3 Nwo+ID4gPiA+ID4gPiA+IDkyCj4gPiA+ID4gPiA+ID4gRml4ZXM6IGM0NDMwMWZjZTYxNCAoImRy bS9pOTE1OiBBbGxvdyBjb250cm9sIG9mIFBTUiBhdAo+ID4gPiA+ID4gPiA+IHJ1bnRpbWUgdGhy b3VnaCBkZWJ1Z2ZzLCB2NiIpCj4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2ls c29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiA+ID4gPiA+ID4gQ2M6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiA+ ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ID4gPiA+ID4g PiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+ Cj4gPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3Bzci5jIHwgMTYgKysrKysrKysrKy0tLS0tLQo+ID4gPiA+ID4gPiA+ICAxIGZpbGUgY2hh bmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiA+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMK PiA+ID4gPiA+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+ID4g PiA+ID4gaW5kZXggMjE5ODRkNGMwOGVkLi5iZGRjOWM3YzY4MWUgMTAwNjQ0Cj4gPiA+ID4gPiA+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ID4gPiA+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiA+ID4gPiA+IEBAIC04 MzQsNiArODM0LDcgQEAgaW50IGludGVsX3Bzcl9zZXRfZGVidWdmc19tb2RlKHN0cnVjdAo+ID4g PiA+ID4gPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiA+ID4gPiA+ICAgICAg IHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRybTsKPiA+ID4gPiA+ID4gPiAg ICAgICBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPiA+ID4gPiA+ID4g PiAgICAgICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9IE5VTEw7Cj4gPiA+ ID4gPiA+ID4gKyAgICAgc3RydWN0IGRybV9jcnRjX2NvbW1pdCAqY29tbWl0ID0gTlVMTDsKPiA+ ID4gPiA+ID4gPiAgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gPiA+ID4gPiA+ID4gICAg ICAgc3RydWN0IGludGVsX2RwICpkcDsKPiA+ID4gPiA+ID4gPiAgICAgICBpbnQgcmV0Owo+ID4g PiA+ID4gPiA+IEBAIC04NjAsMTIgKzg2MSwxNSBAQCBpbnQgaW50ZWxfcHNyX3NldF9kZWJ1Z2Zz X21vZGUoc3RydWN0Cj4gPiA+ID4gPiA+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g PiA+ID4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+ID4gPiA+ ID4gIAo+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2Ny dGNfc3RhdGUoY3J0Yy0KPiA+ID4gPiA+ID4gPiA+c3RhdGUpOwo+ID4gPiA+ID4gPiA+IC0gICAg ICAgICAgICAgcmV0ID0KPiA+ID4gPiA+ID4gPiB3YWl0X2Zvcl9jb21wbGV0aW9uX2ludGVycnVw dGlibGUoJmNydGNfc3RhdGUtPmJhc2UuY29tbWl0LQo+ID4gPiA+ID4gPiA+ID5od19kb25lKTsK PiA+ID4gPiA+ID4gPiAtICAgICB9IGVsc2UKPiA+ID4gPiA+ID4gPiAtICAgICAgICAgICAgIHJl dCA9Cj4gPiA+ID4gPiA+ID4gd2FpdF9mb3JfY29tcGxldGlvbl9pbnRlcnJ1cHRpYmxlKCZjb25u X3N0YXRlLT5jb21taXQtCj4gPiA+ID4gPiA+ID4gPmh3X2RvbmUpOwo+ID4gPiA+ID4gPiA+IC0K PiA+ID4gPiA+ID4gPiAtICAgICBpZiAocmV0KQo+ID4gPiA+ID4gPiA+IC0gICAgICAgICAgICAg cmV0dXJuIHJldDsKPiA+ID4gPiA+ID4gPiArICAgICAgICAgICAgIGNvbW1pdCA9IGNydGNfc3Rh dGUtPmJhc2UuY29tbWl0Owo+ID4gPiA+ID4gPiA+ICsgICAgIH0gZWxzZSB7Cj4gPiA+ID4gPiA+ ID4gKyAgICAgICAgICAgICBjb21taXQgPSBjb25uX3N0YXRlLT5jb21taXQ7Cj4gPiA+ID4gPiA+ IAo+ID4gPiA+ID4gPiBJIGNhbid0IGV2ZW4gZmluZCB3aGVyZSB3ZSBjbGVhciBzdGF0ZS0+Y29t bWl0IGFmdGVyIGl0cwo+ID4gPiA+ID4gPiBkb25lLgo+ID4gPiA+ID4gPiBEbyB3ZSBqdXN0IGxl YXZlIGl0IHBvaW50aW5nIGF0IGZyZWVkIG1lbW9yeSBvciBzb21ldGhpbmc/Cj4gPiA+ID4gPiA+ IEFsc28gSQo+ID4gPiA+ID4gPiBjYW4ndCBmaWd1cmUgb3V0IHdoeSBkcm1fYXRvbWljX2hlbHBl cl9jb21taXRfaHdfZG9uZSgpCj4gPiA+ID4gPiA+IGNvcGllcwo+ID4gPiA+ID4gPiB0aGUgY29t bWl0IGFsc28gdG8gdGhlIG9sZCBzdGF0ZS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gTGV0IG1lIGJl IHRoZSBtZXNzZW5nZXIgdGhlbiA7KSBjb21taXQgaXMgTlVMTCBhdCB0aGlzIHBvaW50LCBJCj4g PiA+ID4gPiBqdXN0Cj4gPiA+ID4gPiBwcmVzdW1lZCBpdCB3YXMgaW50ZW50aW9uYWwuCj4gPiA+ ID4gCj4gPiA+ID4gTXkgZXhwZWN0YXRpb24gd291bGQgYmUgdGhhdCBpdCBnZXRzIGNsZWFyZWQg c29tZXdoZXJlLCBidXQgSQo+ID4gPiA+IHNpbXBseQo+ID4gPiA+IGNhbid0IGZpbmQgYW55IHN1 Y2ggY29kZS4KPiA+ID4gCj4gPiA+IEFjdHVhbGx5IGl0IGxvb2tzIGxpa2UgdGhlcmUgaXMgbm8g c3VjaCBjb2RlLiBUaGUgZXZlbnQgYmFzZWQKPiA+ID4gcmVsZWFzZV9jcnRjX2NvbW1pdCgpIHRo aW5nIGdldHMgaXRzIG93biByZWZlcmVuY2Ugc28gcHJlc3VtYWJseQo+ID4gPiB0aGUKPiA+ID4g b3JpZ2luYWwgcmVmZXJlbmNlIHN0YXlzIHdpdGggdGhlIHN0YXRlIHVudGlsIHRoZSBzdGF0ZSBp dHNlbGYgZ2V0cwo+ID4gPiBkZXN0cm95ZWQuCj4gPiAKPiA+IEhhcHB5IHdpdGggdGhlIGl0IG5l dmVyIGhhZCBhIGNvbW1pdCB0aGVvcnksIG9yIGlzIHRoaXMgYSBkZWVwZXIKPiA+IHByb2JsZW0K PiA+IHRoYXQgbmVlZHMgcm9vdCBjYXVzaW5nPwo+IAo+IEp1c3Qgc28gdGhhdCBJIHVuZGVyc3Rh bmQgdGhpcyBjb3JyZWN0bHksIGV2ZW4gaWYgdGhlcmUgd2FzIGEgcHJpb3IKPiBjb21taXQsIHN0 YXRlLT5jb21taXQgd291bGQgaGF2ZSBiZWVuIGZyZWVkIHdoZW4gY29tcGxldGlvbiB3YXMKPiBz aWduYWxlZC4gSXMgdGhhdCByaWdodD8KCk5haCwgbG9va3MgbGlrZSBpdCdzIGdvaW5nIHRvIGhh bmcgb24gdG8gdGhlIGNvbW1pdCBhcyBsb25nIGFzIHRoZQpzdGF0ZSBleGlzdHMuIEF0IGxlYXN0 IHRoYXQncyBteSByZWFkaW5nIG9mIHRoZSBhdG9taWMgaGVscGVyLgpPciBtYXliZSBJJ20gbWlz c2luZyBzb21ldGhpbmcgY2xldmVyPyBEYW5pZWwvTWFhcnRlbj8KCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==