All of lore.kernel.org
 help / color / mirror / Atom feed
From: Georgii Staroselskii <georgii.staroselskii@emlid.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/5] x86: tangier: pinmux: add API to configure protected pins
Date: Wed, 5 Sep 2018 18:44:29 +0300	[thread overview]
Message-ID: <20180905154429.GA5341@softcrasher> (raw)
In-Reply-To: <CAPnjgZ2EMDvmc71TRbxttf=h=AB71Da0PChDKLYnL8vHeO1SiQ@mail.gmail.com>

On Wed, Sep 05, 2018 at 09:24:40AM -0600, Simon Glass wrote:
> Hi Georgi,
> 
> On 4 September 2018 at 07:34, Georgii Staroselskii
> <georgii.staroselskii@emlid.com> wrote:
> > This API is going to be used to configure some pins that are protected
> > for simple modification.
> >
> > It's not a comprehensive pinctrl driver but can be turned into one
> > when we need this in the future. Now it is planned to be used only
> > in one place. So that's why I decided not to pollute the codebase with a
> > full-blown pinctrl-merrifield nobody will use.
> >
> > This driver reads corresponding fields in DT and configures pins
> > accordingly.
> >
> > The "protected" flag is used to distinguish configuration of SCU-owned
> > pins from the ordinary ones.
> >
> > The code has been adapted from Linux work done by Andy Shevchenko
> > in pinctrl-merrfifield.c
> >
> > Signed-off-by: Georgii Staroselskii <georgii.staroselskii@emlid.com>
> > ---
> >  arch/x86/cpu/tangier/Makefile |   2 +-
> >  arch/x86/cpu/tangier/pinmux.c | 196 ++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 197 insertions(+), 1 deletion(-)
> >  create mode 100644 arch/x86/cpu/tangier/pinmux.c
> >
> 
> Please can you use the livetree API (dev_read_...)?
> 
> Regards,
> Simon

Sure. Will do. It will need CONFIG_OF_LIVE=y for edison_defconfig to be
set. Is there any other modifications or possible regressions that I need
to take into account? Or if I just stick to doc/driver-model/livetree.txt
things should go smoothly?

  reply	other threads:[~2018-09-05 15:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 14:34 [U-Boot] [PATCH v2 0/5] Add a pinctrl driver for Merrifield to pinmux I2C#6 Georgii Staroselskii
2018-09-04 14:34 ` [U-Boot] [PATCH v2 1/5] x86: cpu: introduce scu_ipc_raw_command() Georgii Staroselskii
2018-09-04 14:34 ` [U-Boot] [PATCH v2 2/5] x86: tangier: pinmux: add API to configure protected pins Georgii Staroselskii
2018-09-04 14:57   ` Andy Shevchenko
2018-09-05 15:24   ` Simon Glass
2018-09-05 15:44     ` Georgii Staroselskii [this message]
2018-09-09  1:06       ` Simon Glass
2018-09-04 14:34 ` [U-Boot] [PATCH v2 3/5] x86: dts: edison: configure I2C#6 pins Georgii Staroselskii
2018-09-04 14:34 ` [U-Boot] [PATCH v2 4/5] x86: tangier: acpi: add I2C6 node Georgii Staroselskii
2018-09-04 14:34 ` [U-Boot] [PATCH v2 5/5] x86: cpu: add docstring to scu_ipc_command() Georgii Staroselskii
2018-09-04 14:58   ` Andy Shevchenko
2018-09-05  4:40 ` [U-Boot] [PATCH v2 0/5] Add a pinctrl driver for Merrifield to pinmux I2C#6 Bin Meng
2018-09-05 10:58   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905154429.GA5341@softcrasher \
    --to=georgii.staroselskii@emlid.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.