From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 719B3C433F5 for ; Wed, 5 Sep 2018 17:32:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 169762075E for ; Wed, 5 Sep 2018 17:32:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 169762075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbeIEWED (ORCPT ); Wed, 5 Sep 2018 18:04:03 -0400 Received: from mga04.intel.com ([192.55.52.120]:19139 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727195AbeIEWED (ORCPT ); Wed, 5 Sep 2018 18:04:03 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Sep 2018 10:32:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,334,1531810800"; d="scan'208";a="83311370" Received: from gsharm2-mobl1.amr.corp.intel.com (HELO localhost) ([10.249.37.218]) by fmsmga002.fm.intel.com with ESMTP; 05 Sep 2018 10:32:48 -0700 Date: Wed, 5 Sep 2018 20:32:48 +0300 From: Jarkko Sakkinen To: Dave Hansen Cc: Andy Shevchenko , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kernel Mailing List Subject: Re: [PATCH v13 04/13] x86/sgx: Architectural structures Message-ID: <20180905173248.GD11368@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-5-jarkko.sakkinen@linux.intel.com> <83f5ec5f-1b31-15eb-7341-84ee9c7977e2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83f5ec5f-1b31-15eb-7341-84ee9c7977e2@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 04, 2018 at 09:04:44AM -0700, Dave Hansen wrote: > On 09/03/2018 06:16 AM, Andy Shevchenko wrote: > >> + EBLOCK = 0x9, > >> + EPA = 0xA, > >> + EWB = 0xB, > >> + ETRACK = 0xC, > >> + EAUG = 0xD, > >> + EMODPR = 0xE, > >> + EMODT = 0xF, > >> +}; > > Hmm... This E prefix confuses me with (system wide) error codes. Has > > it been discussed before? If so, can you point on the conclusion why > > the current format is good? > > Making them SGX_EWHATEVER isn't a horrible idea. OK, going with that. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 5 Sep 2018 20:32:48 +0300 From: Jarkko Sakkinen To: Dave Hansen CC: Andy Shevchenko , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , , , , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kernel Mailing List Subject: Re: [PATCH v13 04/13] x86/sgx: Architectural structures Message-ID: <20180905173248.GD11368@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-5-jarkko.sakkinen@linux.intel.com> <83f5ec5f-1b31-15eb-7341-84ee9c7977e2@intel.com> Content-Type: text/plain; charset="us-ascii" In-Reply-To: <83f5ec5f-1b31-15eb-7341-84ee9c7977e2@intel.com> Return-Path: jarkko.sakkinen@linux.intel.com MIME-Version: 1.0 List-ID: On Tue, Sep 04, 2018 at 09:04:44AM -0700, Dave Hansen wrote: > On 09/03/2018 06:16 AM, Andy Shevchenko wrote: > >> + EBLOCK = 0x9, > >> + EPA = 0xA, > >> + EWB = 0xB, > >> + ETRACK = 0xC, > >> + EAUG = 0xD, > >> + EMODPR = 0xE, > >> + EMODT = 0xF, > >> +}; > > Hmm... This E prefix confuses me with (system wide) error codes. Has > > it been discussed before? If so, can you point on the conclusion why > > the current format is good? > > Making them SGX_EWHATEVER isn't a horrible idea. OK, going with that. /Jarkko