All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] screen: fix rare build failure on T_N undeclared
@ 2018-09-05 17:26 Fabrice Fontaine
  2018-09-05 19:14 ` Thomas Petazzoni
  2018-09-28 12:44 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2018-09-05 17:26 UTC (permalink / raw)
  To: buildroot

/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/host/bin/arm-none-linux-gnueabi-gcc -c -I. -I.  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DETCSCREENRC='"/usr/etc/screenrc"' -DSCREENENCODINGS='"/usr/share/screen/utf8encodings"' -DHAVE_CONFIG_H -DGIT_REV=\"\" \
     -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -D_GNU_SOURCE list_display.c
In file included from screen.h:150:0,
                 from list_display.c:36:
display.h:154:19: error: 'T_N' undeclared here (not in a function)
   union tcu d_tcs[T_N];  /* terminal capabilities */

Macro T_N is defined in header file term.h but it may not be created
then fails. Backport patch to make sure term.h is created before compile
other source codes.

Fixes:
 - http://autobuild.buildroot.org/results/a62bea1fd32246526d59f029df3dca60f1cd710f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 .../0010-comm-h-now-depends-on-term-h.patch   | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 package/screen/0010-comm-h-now-depends-on-term-h.patch

diff --git a/package/screen/0010-comm-h-now-depends-on-term-h.patch b/package/screen/0010-comm-h-now-depends-on-term-h.patch
new file mode 100644
index 0000000000..6ff6f3da0b
--- /dev/null
+++ b/package/screen/0010-comm-h-now-depends-on-term-h.patch
@@ -0,0 +1,28 @@
+From 39c5f1c76f1fcef4b5958bf828a63f53426b6984 Mon Sep 17 00:00:00 2001
+From: Mike Gerwitz <mike@mikegerwitz.com>
+Date: Tue, 24 Dec 2013 22:16:31 -0500
+Subject: comm.h now depends on term.h
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Patch retrieved and updated from:
+http://git.savannah.gnu.org/cgit/screen.git/commit/?id=39c5f1c]
+---
+ src/Makefile.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.in b/Makefile.in
+index e791e79..d4f7c0b 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -113,7 +113,7 @@ term.h: term.c term.sh
+ 
+ kmapdef.c: term.h
+ 
+-comm.h: comm.c comm.sh config.h
++comm.h: comm.c comm.sh config.h term.h
+ 	AWK=$(AWK) CC="$(CC) $(CFLAGS)" srcdir=${srcdir} sh $(srcdir)/comm.sh
+ 
+ docs:
+-- 
+cgit v1.0-41-gc330
+
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] screen: fix rare build failure on T_N undeclared
  2018-09-05 17:26 [Buildroot] [PATCH 1/1] screen: fix rare build failure on T_N undeclared Fabrice Fontaine
@ 2018-09-05 19:14 ` Thomas Petazzoni
  2018-09-28 12:44 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-09-05 19:14 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed,  5 Sep 2018 19:26:44 +0200, Fabrice Fontaine wrote:
> /usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/host/bin/arm-none-linux-gnueabi-gcc -c -I. -I.  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DETCSCREENRC='"/usr/etc/screenrc"' -DSCREENENCODINGS='"/usr/share/screen/utf8encodings"' -DHAVE_CONFIG_H -DGIT_REV=\"\" \
>      -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -D_GNU_SOURCE list_display.c
> In file included from screen.h:150:0,
>                  from list_display.c:36:
> display.h:154:19: error: 'T_N' undeclared here (not in a function)
>    union tcu d_tcs[T_N];  /* terminal capabilities */
> 
> Macro T_N is defined in header file term.h but it may not be created
> then fails. Backport patch to make sure term.h is created before compile
> other source codes.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/a62bea1fd32246526d59f029df3dca60f1cd710f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0010-comm-h-now-depends-on-term-h.patch   | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 package/screen/0010-comm-h-now-depends-on-term-h.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] screen: fix rare build failure on T_N undeclared
  2018-09-05 17:26 [Buildroot] [PATCH 1/1] screen: fix rare build failure on T_N undeclared Fabrice Fontaine
  2018-09-05 19:14 ` Thomas Petazzoni
@ 2018-09-28 12:44 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-09-28 12:44 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > /usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/host/bin/arm-none-linux-gnueabi-gcc -c -I. -I.  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DETCSCREENRC='"/usr/etc/screenrc"' -DSCREENENCODINGS='"/usr/share/screen/utf8encodings"' -DHAVE_CONFIG_H -DGIT_REV=\"\" \
 >      -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os  -D_GNU_SOURCE list_display.c
 > In file included from screen.h:150:0,
 >                  from list_display.c:36:
 > display.h:154:19: error: 'T_N' undeclared here (not in a function)
 >    union tcu d_tcs[T_N];  /* terminal capabilities */

 > Macro T_N is defined in header file term.h but it may not be created
 > then fails. Backport patch to make sure term.h is created before compile
 > other source codes.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/a62bea1fd32246526d59f029df3dca60f1cd710f

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2018.02.x and 2018.05.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-28 12:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 17:26 [Buildroot] [PATCH 1/1] screen: fix rare build failure on T_N undeclared Fabrice Fontaine
2018-09-05 19:14 ` Thomas Petazzoni
2018-09-28 12:44 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.