All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-mtd@lists.infradead.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] arch/sh: fix build warning in mach-kfr2r09/setup.c
Date: Wed, 5 Sep 2018 22:34:19 +0200	[thread overview]
Message-ID: <20180905223419.057a7c39@xps13> (raw)
In-Reply-To: <bad8a4af-a99d-c1ea-3494-02dbb0a47f6b@infradead.org>

Hi Randy,

Randy Dunlap <rdunlap@infradead.org> wrote on Wed, 5 Sep 2018 11:17:26
-0700:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> arch/sh/boards/mach-kfr2r09/setup.c does not need to #include
> <mtd/onenand.h>, and doing so causes a build warning, so drop
> that header file.
> 
> In file included from ../arch/sh/boards/mach-kfr2r09/setup.c:28:
> ../include/linux/mtd/onenand.h:225:12: warning: 'struct mtd_oob_ops' declared inside parameter list will not be visible outside of this definition or declaration
>      struct mtd_oob_ops *ops);
> 
> Fixes: f3590dc32974 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera driver")
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Suggested-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: linux-mtd@lists.infradead.org
> ---
>  arch/sh/boards/mach-kfr2r09/setup.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- lnx-419-rc1.orig/arch/sh/boards/mach-kfr2r09/setup.c
> +++ lnx-419-rc1/arch/sh/boards/mach-kfr2r09/setup.c
> @@ -25,7 +25,6 @@
>  #include <linux/memblock.h>
>  #include <linux/mfd/tmio.h>
>  #include <linux/mmc/host.h>
> -#include <linux/mtd/onenand.h>
>  #include <linux/mtd/physmap.h>
>  #include <linux/platform_data/lv5207lp.h>
>  #include <linux/platform_device.h>
> 
> 

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

      reply	other threads:[~2018-09-05 20:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 18:17 [PATCH] arch/sh: fix build warning in mach-kfr2r09/setup.c Randy Dunlap
2018-09-05 20:34 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905223419.057a7c39@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=magnus.damm@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.