All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Karthik B S <karthik.b.s@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915/icl: Update result lines in correspondence with result blocks
Date: Wed, 5 Sep 2018 16:42:30 -0700	[thread overview]
Message-ID: <20180905234230.GH2686@intel.com> (raw)
In-Reply-To: <1536138159-10842-2-git-send-email-karthik.b.s@intel.com>


The subject here is marked as icl, but the code seems to all platforms
what am I missing?

But also I didn't check spec yet on this particular case

On Wed, Sep 05, 2018 at 02:32:39PM +0530, Karthik B S wrote:
> As the result blocks for WM1-WM7 are always kept higher than the
> level below the present level, make sure result lines are also higher
> than the level below for WM1-WM7.
> 
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index b5db6a3..cc41009 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4704,6 +4704,8 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,
>  	if (level >= 1 && level <= 7) {
>  		if (result_prev->plane_res_b > res_blocks)
>  			res_blocks = result_prev->plane_res_b;
> +		if (result_prev->plane_res_l > res_lines)
> +			res_lines = result_prev->plane_res_l;
>  	}
>  
>  	if (INTEL_GEN(dev_priv) >= 11) {
> -- 
> 2.7.4
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-09-05 23:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  9:02 [PATCH v2 1/2] drm/i915/icl: Avoid Gen10 watermark workarounds in Gen11 Karthik B S
2018-09-05  9:02 ` [PATCH v2 2/2] drm/i915/icl: Update result lines in correspondence with result blocks Karthik B S
2018-09-05 23:42   ` Rodrigo Vivi [this message]
2018-09-06  9:39     ` B S, Karthik
2018-09-06 10:27       ` [PATCH v3 2/2] drm/i915/skl+: " Karthik B S
2018-09-05  9:47 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/icl: Avoid Gen10 watermark workarounds in Gen11 Patchwork
2018-09-05 10:38 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-05 23:41 ` [PATCH v2 1/2] " Rodrigo Vivi
2018-10-11 17:45   ` Paulo Zanoni
2018-09-06 13:35 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/icl: Avoid Gen10 watermark workarounds in Gen11 (rev2) Patchwork
2018-09-06 15:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-09-07  5:25 ` ✓ Fi.CI.BAT: success " Patchwork
2018-09-07  7:18 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905234230.GH2686@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.