From: Borislav Petkov <bp@suse.de>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "Brijesh Singh" <brijesh.singh@amd.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, "Tom Lendacky" <thomas.lendacky@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active
Date: Thu, 6 Sep 2018 16:44:44 +0200 [thread overview]
Message-ID: <20180906144444.GC11144@zn.tnic> (raw)
In-Reply-To: <20180906141825.GB370@linux.intel.com>
On Thu, Sep 06, 2018 at 07:18:25AM -0700, Sean Christopherson wrote:
> Oh, and we'd need to make sure __decrypted_exclusive is freed when
> !CONFIG_AMD_MEM_ENCRYPT, and preferably !sev_active() since the big
> array is used only if SEV is active. This patch unconditionally
> defines hv_clock_dec but only frees it if CONFIG_AMD_MEM_ENCRYPT=y &&
> !mem_encrypt_active().
We should not go nuts and complicate the code only to save us a couple
of KBs.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2018-09-06 14:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 11:42 [PATCH v5 0/5] x86: Fix SEV guest regression Brijesh Singh
2018-09-06 11:42 ` [PATCH v5 1/5] x86/mm: Restructure sme_encrypt_kernel() Brijesh Singh
2018-09-06 11:42 ` [PATCH v5 2/5] x86/mm: fix sme_populate_pgd() to update page flags Brijesh Singh
2018-09-06 11:43 ` [PATCH v5 3/5] x86/mm: add .data..decrypted section to hold shared variables Brijesh Singh
2018-09-06 11:43 ` [PATCH v5 4/5] x86/kvm: use __decrypted attribute in " Brijesh Singh
2018-09-06 11:43 ` [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active Brijesh Singh
2018-09-06 12:24 ` Borislav Petkov
2018-09-06 13:50 ` Sean Christopherson
2018-09-06 14:18 ` Sean Christopherson
2018-09-06 14:44 ` Borislav Petkov [this message]
2018-09-06 18:37 ` Brijesh Singh
2018-09-06 18:47 ` Sean Christopherson
2018-09-06 19:24 ` Brijesh Singh
2018-09-06 19:46 ` Brijesh Singh
2018-09-06 19:47 ` Sean Christopherson
2018-09-06 20:20 ` Brijesh Singh
2018-09-06 20:39 ` Sean Christopherson
2018-09-06 21:56 ` Brijesh Singh
2018-09-06 14:43 ` Borislav Petkov
2018-09-06 14:56 ` Sean Christopherson
2018-09-06 15:19 ` Borislav Petkov
2018-09-06 15:54 ` Sean Christopherson
2018-09-06 18:33 ` Borislav Petkov
2018-09-06 18:43 ` Brijesh Singh
2018-09-06 18:45 ` Sean Christopherson
2018-09-06 19:03 ` Borislav Petkov
2018-09-06 17:50 ` Brijesh Singh
2018-09-06 14:07 ` Sean Christopherson
2018-09-06 18:50 ` Brijesh Singh
2018-09-07 3:57 ` Brijesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906144444.GC11144@zn.tnic \
--to=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.