From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: dingxiang@cmss.chinamobile.com
Cc: ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: txx9: fix iounmap related issue
Date: Fri, 07 Sep 2018 00:04:07 +0900 (JST) [thread overview]
Message-ID: <20180907.000407.1493498061297805737.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <1536207559-31543-1-git-send-email-dingxiang@cmss.chinamobile.com>
On Thu, 6 Sep 2018 12:19:19 +0800, Ding Xiang <dingxiang@cmss.chinamobile.com> wrote:
> if device_register return error, iounmap should be called, also iounmap
> need to call before put_device.
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> arch/mips/txx9/generic/setup.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Thank you for fixing this long standing issue. It looks OK for me.
Reviewed-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
---
Atsushi Nemoto
next prev parent reply other threads:[~2018-09-06 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 4:19 [PATCH] mips: txx9: fix iounmap related issue Ding Xiang
2018-09-06 15:04 ` Atsushi Nemoto [this message]
2018-09-06 21:16 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907.000407.1493498061297805737.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=dingxiang@cmss.chinamobile.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.