Hi Charles, I love your patch! Yet something to improve: [auto build test ERROR on ljones-mfd/for-mfd-next] [also build test ERROR on v4.19-rc2 next-20180906] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Charles-Keepax/mfd-lochnagar-Add-support-for-the-Cirrus-Logic-Lochnagar/20180907-010308 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next config: alpha-allmodconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=alpha All errors (new ones prefixed by >>): drivers/mfd/lochnagar-i2c.o: In function `lochnagar_i2c_probe': >> (.text+0x4ec): undefined reference to `__devm_regmap_init_i2c' (.text+0x500): undefined reference to `__devm_regmap_init_i2c' drivers/mfd/lochnagar-i2c.o: In function `lochnagar_i2c_init': >> (.init.text+0x10): undefined reference to `i2c_register_driver' (.init.text+0x24): undefined reference to `i2c_register_driver' --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation